Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document provided scope dependency on scala-reflect #236

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Document provided scope dependency on scala-reflect #236

merged 1 commit into from
Feb 13, 2020

Conversation

dn-mib
Copy link
Contributor

@dn-mib dn-mib commented Feb 5, 2020

@dn-mib dn-mib requested a review from SethTisue February 5, 2020 08:25
@SethTisue SethTisue requested a review from retronym February 5, 2020 16:29
SethTisue
SethTisue approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on my understanding from what I read on the ticket, final review/merge by @retronym though

@SethTisue SethTisue merged commit 96af417 into scala:master Feb 13, 2020
@SethTisue
Copy link
Member

thank you @dn-mib!

@dn-mib
Copy link
Contributor Author

dn-mib commented Feb 14, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethTisue SethTisue SethTisue approved these changes

@retronym retronym retronym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dn-mib @SethTisue @retronym