Latest 2.13.x with Stepper and Accumulator tests. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ichoran are you planning to return to this? |
|
Oh. Um. I didn't realize the tests were failing. I'll try to get to it over the weekend. |
|
(merged in a 2.13.1 -> 2.13.3 upgrade) |
NthPortal
reviewed
Dec 28, 2020
| val LISTBUF_PIP_11438 = F // ListBuffer throws an exception on a no-op patchInPlace | ||
| val QUEUE_SLIDE_11440 = F // Queue and ArrayStack will not give you an underfull sliding window (everything else does) | ||
| val PQ_MIP_NPE_11439 = F // Priority Queue can just give null when empty! | ||
| val LISTBUF_PIP_11438 = X // ListBuffer throws an exception on a no-op patchInPlace |
There was a problem hiding this comment.
these all appear to be fixed
|
Oops, I got sick instead of getting to this, and then forgot about it. I'll try to get to it in the next couple of weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra tests including Stepper and Accumulator.