Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Governance section #1504

Merged
merged 8 commits into from
Jun 2, 2023
Merged

Governance section #1504

merged 8 commits into from
Jun 2, 2023

Conversation

anatoliykmetyuk
Copy link
Contributor

@anatoliykmetyuk anatoliykmetyuk commented May 22, 2023

@bishabosha bishabosha force-pushed the governance-block branch 4 times, most recently from 12655b1 to d3479ee Compare May 24, 2023 14:58
@bishabosha bishabosha assigned darjutak and julienrf and unassigned bishabosha May 24, 2023
@bishabosha bishabosha requested review from darjutak and julienrf and removed request for bishabosha May 24, 2023 15:10
@bishabosha bishabosha marked this pull request as ready for review May 24, 2023 15:10
@bishabosha bishabosha changed the title Governance block draft Governance section May 24, 2023
Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about something about the Scala Center advisory board (including community rep(s))?

_data/governance.yml Outdated Show resolved Hide resolved
_data/governance.yml Outdated Show resolved Hide resolved
@bishabosha
Copy link
Member

bishabosha commented May 25, 2023

Here is what It looks like when I move the "update frequency" box into a separate paragraph.

Screenshot 2023-05-25 at 13 30 46

introText: This section is updated every 6 months by the Scala Center.
cards:
- title: "Scala Improvement Process"
description: "The SIP is the primary mechanism for evolving the Scala language."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to expand a little bit the description. What about the following?

This process aims to evolve Scala openly and collaboratively. Anyone from the community is welcome to submit a Scala Improvement Proposal (SIP), which is then reviewed and discussed by a Committee. Every month, the Committee votes on the proposals to accept in the language.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, but this will take many lines of text, is it ok to go in the expanded section?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I find the current description too short: it does not really provides anything in addition to the title. Is it a problem to make descriptions a bit longer?

Copy link
Member

@bishabosha bishabosha May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the context of being the top of the community page, it adds a lot of vertical space, also the other boxes don't have a similar amount of text, so leading to empty space

_data/governance.yml Outdated Show resolved Hide resolved
Comment on lines +14 to +18
links:
- name: Core Maintainers
url: https://github.com/lampepfl/dotty/blob/main/MAINTENANCE.md#compiler
- name: Maintenance Procedures
url: https://github.com/lampepfl/dotty/blob/main/MAINTENANCE.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too, both links point to the same page. Also, that page dives deep into the issue supervisor role without giving an overview of all the organizations (I see at least LAMP and VirtusLab) involved in the maintenance of the compiler and their respective role.

Last, the description above mentions the standard library and the documentation, which are not covered by the links.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This information should probably be added to the MAINTENANCE.md as a separate PR.

url: https://docs.scala-lang.org/sips/process-specification.html#the-sip-committee
- name: SIP Process Specification
url: https://docs.scala-lang.org/sips/process-specification.html
- title: "Scala 3 Maintenance"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should cover both Scala 2 and Scala 3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lrytz can you help us out here? In terms of the maintenance of Scala 2, what resources can we reference for the current process and people involved?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, those are pretty up to date. If you feel anything is missing, let me know.

description: "Managing build tools, linters, IDEs, and other tools."
expandText: "Process & People"
links:
- text: "Process and People are TBD, please stay tuned! However you can read below about the Scala Tooling Summit:"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this section should be filled before we merge the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current status on this is that we've only conducted one Tooling Summit during which no process was adopted. Changing this might be the goal for the next Summit in September.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if there is no “process”, I would expect the Governance section to give more understanding to the readers about which organizations do exist and actively work on the tooling ecosystem. I think we should mention at least VirtusLab with Scala CLI and Metals, and Jetbrains with IntelliJ.

- name: "Scala Tooling Summit of March 2023"
url: https://www.scala-lang.org/blog/2023/04/11/march-2023-scala-tooling-summit.html
- title: "Moderation"
description: "Learn how the Scala community is moderated."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t have a concrete suggestion to make, but I think the description should summarize what we see in the links (the fact that there is a moderation team, a code of conduct, etc.).

_includes/masthead-community.html Show resolved Hide resolved
@julienrf
Copy link
Contributor

I think there should be a card about the role of the Scala Center: its mission, scope, and funding.

@bishabosha bishabosha marked this pull request as draft May 25, 2023 14:01
@anatoliykmetyuk anatoliykmetyuk requested a review from julienrf May 31, 2023 12:07
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I think it is a good thing to put together those important links here.

I still think we should provide more explanations about the role of every involved organization, but maybe that could be added later if other people agree that this is important.

_data/governance.yml Outdated Show resolved Hide resolved
Comment on lines +54 to +61
- title: "Scala 2 Maintenance"
description: "Who maintains the Scala 2 compiler?"
expandText: "Process & People"
links:
- name: "Contribution Process"
url: "https://github.com/scala/scala#how-to-contribute"
- name: "Core Maintainers"
url: "https://github.com/scala/scala#get-in-touch"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this card. I am a bit confused because its content is pretty different from the Scala 3 Maintenance card. Would it be possible to make them more similar?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would require making the actual processes similar :) which is not the case.

In the case of Scala 3, we have an Issue Supervisor role, which is specced as an actual procedure that we follow weekly to monitor the new issues, identify critical ones, and schedule them in a milestone for fixing. For Scala 2, the link I specified doesn't describe a maintenance procedure but rather how to push your own contribution.

Since the nature of the two documents is so different, I don't think we can't label the Scala 2 link as Maintenance Procedures in the same way the Scala 3 one is called that way.

@@ -0,0 +1,61 @@
introText: This section is updated every 6 months by the Scala Center.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment is not necessary. We should anyway update the content as frequently as necessary (sometimes more than once every six months, but most of the time I guess this will not change within a year).

@SethTisue
Copy link
Member

SethTisue commented Jun 1, 2023

related: scala/scala.epfl.ch#259 ("Make a page dedicated to the community rep")

@anatoliykmetyuk anatoliykmetyuk marked this pull request as ready for review June 2, 2023 08:23
@darjutak
Copy link
Contributor

darjutak commented Jun 2, 2023

Thank you all for creating and updating this page! I'll go ahead and merge it now, but the work is not yet fully done, which is why we added "development of this page progress”.

@darjutak darjutak merged commit ac67bfe into main Jun 2, 2023
@bishabosha bishabosha deleted the governance-block branch November 23, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants