Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Scala 3 the default version #91

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

SethTisue
Copy link
Member

but the code is also still valid Scala 2 code so if someone explicitly chooses Scala 2 instead, that's okay

I removed extends App because it plays no role and because it's problematic in Scala 3

but the code is also still valid Scala 2 code so if someone
explicitly chooses Scala 2 instead, that's okay
@SethTisue SethTisue requested a review from adpi2 November 12, 2024 21:29
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo. Otherwise LGTM

README.md Outdated Show resolved Hide resolved
Co-authored-by: adpi2 <[email protected]>
@SethTisue SethTisue merged commit a2ed824 into scala:main Nov 13, 2024
2 checks passed
@SethTisue SethTisue deleted the scala-3-by-default branch November 13, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants