Fix race condition which could disable saving (#6914)

* provocate bug with sleep * never terminate save saga (to avoid that a temporary allowUpdate=false could mean that changes were never saved) * update changelog * Update CHANGELOG.unreleased.md Co-authored-by: Daniel <[email protected]> * Revert "provocate bug with sleep" This reverts commit 37692e7. --------- Co-authored-by: Daniel <[email protected]>
scalableminds · Mar 13, 2023 · 78466ee · 78466ee
1 parent 0f6233f
commit 78466ee
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md
@@ -23,6 +23,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
 - Fixed a bug where merging multiple volume annotations would result in inconsistent segment lists. [#6882](https://github.com/scalableminds/webknossos/pull/6882)
 - Fixed a bug where uploading multiple annotations with volume layers at once would fail. [#6882](https://github.com/scalableminds/webknossos/pull/6882)
 - Fixed a bug where dates were formatted incorrectly in Voxelytics reports. [#6908](https://github.com/scalableminds/webknossos/pull/6908)
+- Fixed a rare bug which could cause an incorrectly initialized annotation so that changes were not saved in the current session. [#6914](https://github.com/scalableminds/webknossos/pull/6914)
 
 ### Removed
 

diff --git a/frontend/javascripts/oxalis/model/sagas/save_saga.ts b/frontend/javascripts/oxalis/model/sagas/save_saga.ts
@@ -1091,7 +1091,7 @@ export function* setupSavingForTracingType(
     const allowUpdate = yield* select(
       (state) => state.tracing.restrictions.allowUpdate && state.tracing.restrictions.allowSave,
     );
-    if (!allowUpdate) return;
+    if (!allowUpdate) continue;
     const tracing = (yield* select((state) => selectTracing(state, saveQueueType, tracingId))) as
       | VolumeTracing
       | SkeletonTracing;