Adding /api/artifacts/<group_id>/<artifact_id> endpoint
#1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New method: `WebDatabase#getArtifact(Artifact.groupId, Artifact.artifactId)
* Tests added in:
* `ArtifactTableTests.scala`
* `SqlDatabaseTests.scala`
* `Meta` instance created for `Artifact.ArtifactId`.
* Endpoints added along with documentation, return value is of type
`Page[ArtifactMetadataResponse]`.
* `WebDatabase#getArtifact: Future[Option[Artifact]]` has been refactored to
`WebDatabase#getArtifact: Future[Seq[Artifact]]` given the fact that there
can be more than one artifact with the same `group_id` and `artifcact_id`
can be diff. versions.
* Tests added for endpoints.
* Adding a test for `/api/artifacts/<group_id>/<artifact_id>
* Group id is invalid, but artifact id is valid.
* Group id is valid, but artifact id is invalid.
jyoo980
commented
Apr 16, 2022
modules/core/shared/src/main/scala/scaladex/core/api/artifact/ArtifactMetadataResponse.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Work
WebDatabase#getArtifacts(groupId, artifactId): Future[Seq[Artifact]], with associated tests inArtifactTestTable.scalaandSqlDatabaseTests.scala./api/artifacts/<group_id>/<artifact_id>endpoint inArtifactEndpoints, added them toArtifactApi.scala, with associated tests.Closes #998