feat gsn-11659: make logic in line with security hub filtering #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costastf
reviewed
Dec 7, 2024
| return any(search(pattern, resource) | ||
| for resource in self.resource_ids | ||
| for pattern in resource_id_patterns) | ||
| else: |
costastf
reviewed
Dec 7, 2024
| return any(search(pattern, resource) | ||
| for resource in self.resource_ids | ||
| for pattern in resource_id_patterns) | ||
| else: |
costastf
reviewed
Dec 7, 2024
| return any(search(pattern, resource) | ||
| for resource in self.resource_ids | ||
| for pattern in resource_id_patterns) | ||
| else: |
costastf
reviewed
Dec 7, 2024
| return any(search(pattern, resource) | ||
| for resource in self.resource_ids | ||
| for pattern in resource_id_patterns) | ||
| else: |
There was a problem hiding this comment.
Maybe this is nicer?
return (
not resource_id_patterns
or any(search(pattern, resource)
for resource in self.resource_ids
for pattern in resource_id_patterns
)
)
| @@ -311,11 +311,15 @@ def is_matching_resource_ids(self, resource_id_patterns) -> bool: | |||
|
|
|||
| Returns: | |||
| True if any match is found, False otherwise. | |||
| An empty resource_id_patterns list will always return True, like Security Hub does per resource. | |||
There was a problem hiding this comment.
True if any resource ID matches any pattern, or if patterns list is empty. False otherwise.
| return any(search(pattern, resource) | ||
| for resource in self.resource_ids | ||
| for pattern in resource_id_patterns) | ||
| else: |
There was a problem hiding this comment.
Maybe this is nicer?
return (
not resource_id_patterns
or any(search(pattern, resource)
for resource in self.resource_ids
for pattern in resource_id_patterns
)
)
| for rule_tag in rule_tags | ||
| for tag in self.tags) | ||
|
|
||
| if rule_tags: |
There was a problem hiding this comment.
If you like the comment above then to make it consistent:
return (
not rule_tags
or any(
tag.get(rule_tag['key']) == rule_tag.get('value')
for rule_tag in rule_tags
for tag in self.tags
)
)
carlovoSBP
force-pushed
the
gsn-11659-sec-hub-logic
branch
from
7b46666 to
6400d25
Compare
marwinbaumannsbp
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.