fix: SG already exists error when recreating with create_before_destroy by introducing a security_group_name_prefix variable
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Format and Style 🖌
|
stefanwb
force-pushed
the
fix-sg-name
branch
2 times, most recently
from
d5ac309 to
4ddf29f
Compare
stefanwb
changed the title
sg_name_prefix variable that can be used to override the default behaviour where the Lambda's name is used.
stefanwb
changed the title
sg_name_prefix variable that can be used to override the default behaviour where the Lambda's name is used.sg_name_prefix variable
|
@marwinbaumannsbp see updated PR with resolved comments after our conversation |
…destroy by introducing a sg_name_prefix variable that can be used to override the default behaviour where the Lambda's name is used. Signed-off-by: Stefan Wessels Beljaars <[email protected]>
marwinbaumannsbp
force-pushed
the
fix-sg-name
branch
from
26877da to
73e6d3b
Compare
marwinbaumannsbp
force-pushed
the
fix-sg-name
branch
from
c6fdbe1 to
8d4e292
Compare
marwinbaumannsbp
changed the title
sg_name_prefix variable security_group_name_prefix variable
marwinbaumannsbp
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the SG already exists error when recreating with create_before_destroy by introducing a
sg_name_prefixvariable that can be used to override the default behaviour where the Lambda's name is used.