Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: Update all execution role related variables #79

Merged
merged 5 commits into from
Dec 30, 2024

Conversation

marlonparmentier
Copy link
Contributor

@marlonparmentier marlonparmentier commented Dec 27, 2024

This update consists of 2 parts:

(1) Update and rename the role_arn variable to object execution_role_custom.arn to allow proper usage of count.

This update in variable structure is to overcome the error below when supplying your own role_arn in the previous version. Breaking change for people that are using the role_arn.

The "count" value depends on resource attributes that cannot be determined until apply, so Terraform cannot predict how many instances will be created. To work around this, use the -target
argument to first apply only the resources that the count depends on.

(2) Update all other variables related to configuring the modules built in lambda execution role.

See the upgrading guide. A new variable execution_role has been introduced which contains all variables related to configuring the lambda execution role.

Copy link
Contributor

github-actions bot commented Dec 27, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️``

Terraform Lint 📖success

Terraform Validation 🤖success

Validation Output

Success! The configuration is valid.


@marlonparmentier marlonparmentier changed the title Update Role ARN variable to object to allow proper usage of count breaking: Update Role ARN variable to object to allow proper usage of count Dec 27, 2024
@github-actions github-actions bot added the breaking This change is not backwards compatible label Dec 30, 2024
Copy link
Contributor

@marwinbaumannsbp marwinbaumannsbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the UPGRADING.md?

variables.tf Outdated Show resolved Hide resolved
@marwinbaumannsbp marwinbaumannsbp changed the title breaking: Update Role ARN variable to object to allow proper usage of count breaking: Update all execution role related variables Dec 30, 2024
Copy link
Contributor Author

@marlonparmentier marlonparmentier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marwinbaumannsbp marwinbaumannsbp merged commit 9f9c3df into master Dec 30, 2024
@marwinbaumannsbp marwinbaumannsbp deleted the update_role_arn_count branch December 30, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This change is not backwards compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants