-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking: Update all execution role related variables #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Format and Style 🖌
|
marlonparmentier
changed the title
Update Role ARN variable to object to allow proper usage of count
breaking: Update Role ARN variable to object to allow proper usage of count
Dec 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the UPGRADING.md?
marwinbaumannsbp
force-pushed
the
update_role_arn_count
branch
from
December 30, 2024 12:51
c0118ac
to
b3ffd4b
Compare
marwinbaumannsbp
force-pushed
the
update_role_arn_count
branch
from
December 30, 2024 12:56
d01b9d6
to
403ac23
Compare
marwinbaumannsbp
changed the title
breaking: Update Role ARN variable to object to allow proper usage of count
breaking: Update all execution role related variables
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
marwinbaumannsbp
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update consists of 2 parts:
(1) Update and rename the
role_arn
variable to objectexecution_role_custom.arn
to allow proper usage of count.This update in variable structure is to overcome the error below when supplying your own
role_arn
in the previous version. Breaking change for people that are using therole_arn
.(2) Update all other variables related to configuring the modules built in lambda execution role.
See the upgrading guide. A new variable
execution_role
has been introduced which contains all variables related to configuring the lambda execution role.