Skip to content

Commit

Permalink
Fix diagnostic warning re unused SES forwarder alias
Browse files Browse the repository at this point in the history
The provider alias was removed from the ses-forwarder module a while
ago, this commit fixes the warning we get that we are referencing
something that does not exist.

Signed-off-by: Stephen Hoekstra <[email protected]>
  • Loading branch information
shoekstra committed Oct 11, 2024
1 parent e033a01 commit 50fe65b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
*.tfstate
*.tfstate.*

# Lock files
.terraform.lock.hcl

# Crash log files
crash.log

Expand Down
13 changes: 7 additions & 6 deletions ses_accounts_mail_alias.tf
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
module "ses-root-accounts-mail-alias" {
#checkov:skip=CKV_AWS_273: IAM user is the only option for SMTP auth
# checkov:skip=CKV_AWS_273: IAM user is the only option for SMTP auth

count = var.ses_root_accounts_mail_forward != null ? 1 : 0
providers = { aws = aws, aws.route53 = aws }

Expand All @@ -13,11 +14,11 @@ module "ses-root-accounts-mail-alias" {
}

module "ses-root-accounts-mail-forward" {
#checkov:skip=CKV_AWS_19: False positive: https://github.com/bridgecrewio/checkov/issues/3847. The S3 bucket created by this module is encrypted with KMS.
#checkov:skip=CKV_AWS_145: False positive: https://github.com/bridgecrewio/checkov/issues/3847. The S3 bucket created by this module is encrypted with KMS.
#checkov:skip=CKV_AWS_272: This module does not support lambda code signing at the moment
count = var.ses_root_accounts_mail_forward != null ? 1 : 0
providers = { aws = aws, aws.lambda = aws }
# checkov:skip=CKV_AWS_19: False positive: https://github.com/bridgecrewio/checkov/issues/3847. The S3 bucket created by this module is encrypted with KMS.
# checkov:skip=CKV_AWS_145: False positive: https://github.com/bridgecrewio/checkov/issues/3847. The S3 bucket created by this module is encrypted with KMS.
# checkov:skip=CKV_AWS_272: This module does not support lambda code signing at the moment

count = var.ses_root_accounts_mail_forward != null ? 1 : 0

source = "schubergphilis/mcaf-ses-forwarder/aws"
version = "~> 0.3.0"
Expand Down

0 comments on commit 50fe65b

Please sign in to comment.