Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unused SES forwarder alias #212

Merged
merged 1 commit into from
Oct 11, 2024
+10 −6
Merged

fix: Remove unused SES forwarder alias #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
*.tfstate
*.tfstate.*

# Lock files
.terraform.lock.hcl

# Crash log files
crash.log

Expand Down
13 changes: 7 additions & 6 deletions ses_accounts_mail_alias.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
module "ses-root-accounts-mail-alias" {
#checkov:skip=CKV_AWS_273: IAM user is the only option for SMTP auth
# checkov:skip=CKV_AWS_273: IAM user is the only option for SMTP auth

count = var.ses_root_accounts_mail_forward != null ? 1 : 0
providers = { aws = aws, aws.route53 = aws }

Expand All @@ -13,11 +14,11 @@ module "ses-root-accounts-mail-alias" {
}

module "ses-root-accounts-mail-forward" {
#checkov:skip=CKV_AWS_19: False positive: https://github.com/bridgecrewio/checkov/issues/3847. The S3 bucket created by this module is encrypted with KMS.
#checkov:skip=CKV_AWS_145: False positive: https://github.com/bridgecrewio/checkov/issues/3847. The S3 bucket created by this module is encrypted with KMS.
#checkov:skip=CKV_AWS_272: This module does not support lambda code signing at the moment
count = var.ses_root_accounts_mail_forward != null ? 1 : 0
providers = { aws = aws, aws.lambda = aws }
# checkov:skip=CKV_AWS_19: False positive: https://github.com/bridgecrewio/checkov/issues/3847. The S3 bucket created by this module is encrypted with KMS.
# checkov:skip=CKV_AWS_145: False positive: https://github.com/bridgecrewio/checkov/issues/3847. The S3 bucket created by this module is encrypted with KMS.
# checkov:skip=CKV_AWS_272: This module does not support lambda code signing at the moment

count = var.ses_root_accounts_mail_forward != null ? 1 : 0

source = "schubergphilis/mcaf-ses-forwarder/aws"
version = "~> 0.3.0"
Expand Down
Loading