-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated the installation page with tab based navigation #608
updated the installation page with tab based navigation #608
Conversation
…ith tab based navigation
✅ Deploy Preview for scipy-org ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
The PR resolves the Issue: DOC: update installation page #811 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Musharraffaijaz Please use the theme's built-in shortcode for tabs: https://theme.scientific-python.org/shortcodes/#tabs If there are issues with the styling of the built-in tabs, it should be addressed here https://github.com/pydata/pydata-sphinx-theme/ |
Alright, will do the changes. |
…stallation navigation to the themes built-in shortcode for tabs
@jarrodmillman is it possible if we could change the styling of the tabs a bit maybe? Instead of having a border at the top can we just change it to bottom border only and a highlighting on hover? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like how this looks now! One thing - please could you keep the type stubs section separate (i.e. not as a tab)? It's basically something extra to look at after already understanding one of the tabs, rather than instead of the tabs.
Great to know you liked it, sure will keep the type stubs separate. |
We are using the pydata-sphinx-theme styling for the scientific-python-hugo-theme. So you will need to get the changes to the tab styling implemented here: https://github.com/pydata/pydata-sphinx-theme/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this layout, in my opinion it is better UX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the hyperlinks on lines 17 to 20 don't work any more - I think they can just be removed now
…-stubs from the tab-based navigation
@lucascolley is there anything else which needs to be done here? |
… the tabs component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @Musharraffaijaz, this looks good to me and is a nice improvement!
Thanks @lucascolley, I'm glad it was helpful. I'm always looking to learn and improve, so I'd be keen to discuss any other areas in the projects where I could contribute. |
alright, merging - thanks again @Musharraffaijaz ! |
Kindly check the changes, all the installation steps are changed into tab-based navigation
The PR resolves the Issue: DOC: update installation page #811