-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync new Zyte API features #218
base: main
Are you sure you want to change the base?
Conversation
New attribute to take into account: #222 |
We also need to make sure it is possible to disable |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
+ Coverage 97.89% 97.91% +0.02%
==========================================
Files 14 14
Lines 1615 1632 +17
Branches 297 302 +5
==========================================
+ Hits 1581 1598 +17
Misses 14 14
Partials 20 20
|
…nting (some safe scenarios)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't run a real spider with the updated code; the code itself looks good 👍
No description provided.