Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mpt migration related changes #73

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

zimpha
Copy link
Member

@zimpha zimpha commented Jan 20, 2025

No description provided.

@Thegaram Thegaram self-requested a review January 20, 2025 10:40
src/L1/rollup/ScrollChain.sol Outdated Show resolved Hide resolved
src/L1/rollup/ScrollChain.sol Outdated Show resolved Hide resolved
@zimpha zimpha marked this pull request as ready for review January 23, 2025 09:25
Copy link
Contributor

@Thegaram Thegaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good

src/L1/rollup/ScrollChain.sol Outdated Show resolved Hide resolved
src/L1/rollup/ScrollChain.sol Outdated Show resolved Hide resolved
src/L1/rollup/ScrollChain.sol Show resolved Hide resolved
src/L1/rollup/ScrollChain.sol Show resolved Hide resolved
src/L1/rollup/ScrollChain.sol Outdated Show resolved Hide resolved
src/L1/rollup/ScrollChain.sol Outdated Show resolved Hide resolved
Copy link
Contributor

@Thegaram Thegaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see we finally get to deprecate some old code

src/L1/rollup/ScrollChain.sol Show resolved Hide resolved
src/L1/rollup/ScrollChain.sol Show resolved Hide resolved
src/L1/rollup/ScrollChain.sol Outdated Show resolved Hide resolved
src/L1/rollup/ScrollChain.sol Show resolved Hide resolved
src/L1/rollup/ScrollChain.sol Show resolved Hide resolved
src/L1/rollup/ScrollChain.sol Show resolved Hide resolved
}

uint256 _length;
if (version == 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to also remove:

import {BatchHeaderV0Codec} from "../libraries/codec/BatchHeaderV0Codec.sol";
import {BatchHeaderV1Codec} from "../libraries/codec/BatchHeaderV1Codec.sol";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants