Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: requests/issues menu count #3470

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

OwsleyJr
Copy link
Collaborator

@OwsleyJr OwsleyJr commented May 27, 2023

Description

This PR adds a pending and open issues count to the sidebar and the mobile menu. For the design of the counts, I used the badge component and modified the design slightly to make it better fit the sidebar. Used SWR mutation across the app where we update the request/issue data to keep the count number(s) up to date.

  • useSWR added to Layout component.
  • Refer to screenshots for visual.

Screenshot (if UI-related)

Sidebar
Screenshot 2023-05-27 at 5 29 08 PM
Mobile Menu
Screenshot 2023-10-27 at 11 48 40 AM
Mobile Menu Full List
Screenshot 2023-05-27 at 5 29 28 PM

To-Dos

  • Successful build yarn build

Issues Fixed or Closed

@OwsleyJr OwsleyJr force-pushed the feat/requests-count branch from 4a9edea to c5a44e1 Compare May 27, 2023 21:43
@cypress
Copy link

cypress bot commented May 27, 2023

Passing run #2158 ↗︎

0 28 0 0 Flakiness 0

Details:

feat: requests/issues menu count
Project: overseerr Commit: b0160828be
Status: Passed Duration: 03:45 💡
Started: Oct 27, 2023 3:56 PM Ended: Oct 27, 2023 4:00 PM

Review all test suite changes for PR #3470 ↗︎

@OwsleyJr OwsleyJr force-pushed the feat/requests-count branch from c5a44e1 to b5d92ae Compare July 26, 2023 22:50
@stale
Copy link

stale bot commented Oct 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2023
@OwsleyJr OwsleyJr force-pushed the feat/requests-count branch from b5d92ae to b016082 Compare October 27, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numbers representing how many request/issues available or open
1 participant