-
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding anime specific Sonarr/Radarr instance support #3664
base: develop
Are you sure you want to change the base?
feat: Adding anime specific Sonarr/Radarr instance support #3664
Conversation
This is my first time contributing here, so I'm sure there's something I've done wrong :) please let me know. |
Please make this so |
I've noticed that with the current pull request any Anime requests will not fallback to the regular default service instance if there is no default anime service. Making this a breaking change. I think it would be better if this wasn't a breaking change so I will update this with a small ammentmend to make it have a fallback. |
Validated this does now correctly use fallbacks. When requesting anime with just a single default server without changing any settings related to this change, Overseerr will send the request to the default instance. When afterwards setting up another Sonarr instance with the Anime default flag enabled, it routes the requests there instead. |
Might I suggest a slight change to mark the anime settings as required, and normal settings as not required in the event that it is an anime instance? |
I unfortunately don't understand the suggestion. If you could elaborate that would be great. |
As you can see below, the asterisks are denoting the fields are required. Now when setting up an anime server, I imagine that its not the general quality/root folder you are using, but the anime quality/root folder. Therefore is it possible to have the required quality/root folder fields for anime be set to required, while the general ones set to not required when the isAnime tick box is ticked? |
@Feramance as requested, the previous commit marks the Anime-specific dropdown as required. It however does not mark the normal ones as not required. This is because I couldn't find a logical flow in which those could be optional. ![]() |
Not sure how I feel about having two options for profile, folder, etc. when this is for an anime specific Sonarr. The flow would either need to be modified to remove/hide one of them or just completely disable a set of options. |
Hmmm, well I can understand that hiding it would be better. So, I would like to suggest the following scenarios:
This should keep backwards compatibility and give the UI a cleaner look. If this is acceptable I will implement this. |
I do have one other suggestion, though a little extra, it should make everything cleaner.
This both keeps backwards compatibility and more granular control on what service handles what |
I'm fine with either of the above, @OwsleyJr if you could pass your verdict on whichever you prefer, I'll make it so :) |
It's been about a month at this point. Please decide to accept this or not. If it's not wanted that's fine but I'm not one to keep going after open source changes months after a pull request has been made. |
Any update regarding this ? I would love to have this feature so that I can get rid of my other overseerr instance just for anime and stop people from mixing instances and requesting anime on the tv instance or the opposite. |
+1 as well. I've been using the current build and it works great, would really like to see this fully implemented so I don't need to run my own custom version and get get future updates more easily. |
@sct Any feedback? |
Is it possible to have a new docker tag with this PR change installed? At least until @sct responds |
Please? |
Who's task would this be to arrange this temporarily? I'm unfamiliar with Docker packages, but I can try to set it up. |
Continuing conversation of #2876 (comment) here, as it's related to the PR. I will investigate why this doesn't work with requestrr, I personally only use the WebUI so that was my test case. |
@Infray can you share how you've setup your services in Overseerr? Or ping me in the Overseerr Discord, that's likely easier. |
I tested this with Requestrr, seems to request fine, however it doesn't make a distinction between TV shows and anime from the request side, so everything goes to the TV show Sonarr service. I guess it would be up to Requestrr to support requesting anime, or for Overseerr to get the TVDB data on external API requests to determine what kind of request it is. |
Or a change in the API processing to check the tags for the requested show |
I've been running a custom build with this for a while and besides this PR for movie collections I haven't run into any issues, As the description of the PR says though, my modal doesn't seem to have the overrides, and they seem to default to the wrong thing under the hood (normal default instance) so I wasn't sure how to handle that best. Hence why they're just commented out for now. |
Apologies, I lost track of this thread due to real life. |
+1 I just got into overseerr and I run 2 instances of Sonarr like several others so and I'm just not quite savvy enough to be able to modify my docker image of Overseerr to use this myself but if someone could help or this gets it's own docker image and tag that would be beautiful too |
This would solve my super jank solution! Please merge this @OwsleyJr |
This would be awesome if merged!!!! |
built with this included: sct/overseerr#3664
Hey everyone. For any of you who're still following this pull request, eagerly waiting for it to get merged, I went ahead and created a docker image with this PR included in it, based of the latest release as of this writing (v1.33.2). It's based on hotio's docker container, and it auto updates and so on and so forth, like the rest of hotio's container images. So if you're familiar with his docker images, it should be a no-brainer to get it up and running. I added a small README to the page, that should explain the basics. The Docker image can be found here: I haven't tested it very extensively, but it should work, as it's based off of this PR. Be wary it might not work well with request-bots like requestrr and doplarr. Kind regards, |
Regarding the requestrr and doplarr bots, what could cause it to not work? Has this been tested? Would love to use this, but I also make use of those two bots :) |
I haven't tested it really, but looking through the file changes in this PR, you can see there's a new What this means in practice is that the bots will probably "work", until a user request an Anime series or movie. I'm not sure what will happen, but most likely it'll either error out, or place the Anime series or movie in an incorrect folder. |
re #2876
Description
This change adds the option to set a Sonarr or Radarr service as an Anime specific instance.
Adding this helps a number of people who are runnign two instances for separating anime and regular tv shows.
Screenshot (if UI-related)
Adding or Editing services:
![image](https://private-user-images.githubusercontent.com/323329/279069957-ee5fee2a-47cb-4f93-a1f7-76817401b5eb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5Njg3MjcsIm5iZiI6MTczODk2ODQyNywicGF0aCI6Ii8zMjMzMjkvMjc5MDY5OTU3LWVlNWZlZTJhLTQ3Y2ItNGY5My1hMWY3LTc2ODE3NDAxYjVlYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwN1QyMjQ3MDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05MTcxMDYwZDAyNWVlOTlhZGNmNGViMWYwOTMxMWQ1MTE1ZTQ3ZTRjYzlkNzFjYWYwNGZlMGQ0NDU4NjJiMjdhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.ocVfDFPzjWabdYAN7lQvz1bfyomQcG1Se9vF9mFro3A)
To-Dos
yarn build
yarn i18n:extract
Issues Fixed or Closed