Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding anime specific Sonarr/Radarr instance support #3664

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

thempc
Copy link

@thempc thempc commented Oct 30, 2023

re #2876

Description

This change adds the option to set a Sonarr or Radarr service as an Anime specific instance.
Adding this helps a number of people who are runnign two instances for separating anime and regular tv shows.

Screenshot (if UI-related)

Adding or Editing services:
image

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

@thempc
Copy link
Author

thempc commented Oct 30, 2023

This is my first time contributing here, so I'm sure there's something I've done wrong :) please let me know.
I've also just done this based on both my own needs and seemingly the needs of others (looking at the multiple tickets + threads on Discord)

@Feramance
Copy link

Please make this so

@thempc
Copy link
Author

thempc commented Oct 30, 2023

I've noticed that with the current pull request any Anime requests will not fallback to the regular default service instance if there is no default anime service. Making this a breaking change. I think it would be better if this wasn't a breaking change so I will update this with a small ammentmend to make it have a fallback.

@thempc
Copy link
Author

thempc commented Oct 30, 2023

Validated this does now correctly use fallbacks. When requesting anime with just a single default server without changing any settings related to this change, Overseerr will send the request to the default instance. When afterwards setting up another Sonarr instance with the Anime default flag enabled, it routes the requests there instead.

@Feramance
Copy link

Might I suggest a slight change to mark the anime settings as required, and normal settings as not required in the event that it is an anime instance?

@thempc
Copy link
Author

thempc commented Nov 2, 2023

Might I suggest a slight change to mark the anime settings as required, and normal settings as not required in the event that it is an anime instance?

I unfortunately don't understand the suggestion. If you could elaborate that would be great.

@Feramance
Copy link

Might I suggest a slight change to mark the anime settings as required, and normal settings as not required in the event that it is an anime instance?

I unfortunately don't understand the suggestion. If you could elaborate that would be great.

As you can see below, the asterisks are denoting the fields are required. Now when setting up an anime server, I imagine that its not the general quality/root folder you are using, but the anime quality/root folder. Therefore is it possible to have the required quality/root folder fields for anime be set to required, while the general ones set to not required when the isAnime tick box is ticked?

image

@thempc
Copy link
Author

thempc commented Nov 3, 2023

@Feramance as requested, the previous commit marks the Anime-specific dropdown as required. It however does not mark the normal ones as not required. This is because I couldn't find a logical flow in which those could be optional.

image

@OwsleyJr
Copy link
Collaborator

@Feramance as requested, the previous commit marks the Anime-specific dropdown as required. It however does not mark the normal ones as not required. This is because I couldn't find a logical flow in which those could be optional.

image

Not sure how I feel about having two options for profile, folder, etc. when this is for an anime specific Sonarr. The flow would either need to be modified to remove/hide one of them or just completely disable a set of options.

@thempc
Copy link
Author

thempc commented Nov 16, 2023

Hmmm, well I can understand that hiding it would be better. So, I would like to suggest the following scenarios:

  • A user has one server, marked as a regular default server (nothing changes, it accepts both TV and Anime)
  • A user has two servers, one marked regular default and one anime default (here we change the anime interface to hide the regular TV options)
  • A user has one server, marked as default anime (show only the anime settings, and display an error that there is no regular default server)

This should keep backwards compatibility and give the UI a cleaner look. If this is acceptable I will implement this.

@Feramance
Copy link

Hmmm, well I can understand that hiding it would be better. So, I would like to suggest the following scenarios:

  • A user has one server, marked as a regular default server (nothing changes, it accepts both TV and Anime)
  • A user has two servers, one marked regular default and one anime default (here we change the anime interface to hide the regular TV options)
  • A user has one server, marked as default anime (show only the anime settings, and display an error that there is no regular default server)

This should keep backwards compatibility and give the UI a cleaner look. If this is acceptable I will implement this.

I do have one other suggestion, though a little extra, it should make everything cleaner.

  • Add another tick box labeled Series
  • Default Sonarr service will show fields for both Series and Anime
  • If Series is selected then only the fields for general series are shown
  • if Anime is selected then only the fields for anime are shown

This both keeps backwards compatibility and more granular control on what service handles what

@thempc
Copy link
Author

thempc commented Nov 17, 2023

I'm fine with either of the above, @OwsleyJr if you could pass your verdict on whichever you prefer, I'll make it so :)

@OwsleyJr
Copy link
Collaborator

I'm fine with either of the above, @OwsleyJr if you could pass your verdict on whichever you prefer, I'll make it so :)

We might need further input from @sct before going ahead due to this being a big change in the flow.

@thempc
Copy link
Author

thempc commented Dec 20, 2023

It's been about a month at this point. Please decide to accept this or not. If it's not wanted that's fine but I'm not one to keep going after open source changes months after a pull request has been made.

@Quack6765
Copy link

Any update regarding this ? I would love to have this feature so that I can get rid of my other overseerr instance just for anime and stop people from mixing instances and requesting anime on the tv instance or the opposite.

@nrlcode
Copy link

nrlcode commented Jan 23, 2024

+1 as well. I've been using the current build and it works great, would really like to see this fully implemented so I don't need to run my own custom version and get get future updates more easily.

@Feramance
Copy link

@sct Any feedback?

@Feramance
Copy link

Feramance commented Jan 24, 2024

I'm fine with either of the above, @OwsleyJr if you could pass your verdict on whichever you prefer, I'll make it so :)

We might need further input from @sct before going ahead due to this being a big change in the flow.

Is it possible to have a new docker tag with this PR change installed? At least until @sct responds

@solidsnakex37
Copy link

I'm fine with either of the above, @OwsleyJr if you could pass your verdict on whichever you prefer, I'll make it so :)

We might need further input from @sct before going ahead due to this being a big change in the flow.

Is it possible to have a new docker tag with this PR change installed? At least until @sct responds

Please?

@thempc
Copy link
Author

thempc commented Jan 30, 2024

I'm fine with either of the above, @OwsleyJr if you could pass your verdict on whichever you prefer, I'll make it so :)

We might need further input from @sct before going ahead due to this being a big change in the flow.

Is it possible to have a new docker tag with this PR change installed? At least until @sct responds

Please?

Who's task would this be to arrange this temporarily? I'm unfamiliar with Docker packages, but I can try to set it up.

@Vankerkom
Copy link

Vankerkom commented Feb 15, 2024

Hey, @OwsleyJr, @sct , it seems that a few people are eagerly awaiting this feature.
Is there a way to get this approved in the near future?

@thempc
Copy link
Author

thempc commented Mar 23, 2024

Continuing conversation of #2876 (comment) here, as it's related to the PR. I will investigate why this doesn't work with requestrr, I personally only use the WebUI so that was my test case.

@thempc
Copy link
Author

thempc commented Mar 23, 2024

@Infray can you share how you've setup your services in Overseerr? Or ping me in the Overseerr Discord, that's likely easier.

@thempc
Copy link
Author

thempc commented Mar 23, 2024

I tested this with Requestrr, seems to request fine, however it doesn't make a distinction between TV shows and anime from the request side, so everything goes to the TV show Sonarr service. I guess it would be up to Requestrr to support requesting anime, or for Overseerr to get the TVDB data on external API requests to determine what kind of request it is.

@Feramance
Copy link

Or a change in the API processing to check the tags for the requested show

@Plancke
Copy link

Plancke commented May 3, 2024

I've been running a custom build with this for a while and besides this PR for movie collections I haven't run into any issues,

As the description of the PR says though, my modal doesn't seem to have the overrides, and they seem to default to the wrong thing under the hood (normal default instance) so I wasn't sure how to handle that best. Hence why they're just commented out for now.

@Infray
Copy link

Infray commented May 3, 2024

I tested this with Requestrr, seems to request fine, however it doesn't make a distinction between TV shows and anime from the request side, so everything goes to the TV show Sonarr service. I guess it would be up to Requestrr to support requesting anime, or for Overseerr to get the TVDB data on external API requests to determine what kind of request it is.

Apologies, I lost track of this thread due to real life.
@thempc Thanks for looking into this. Doesn't sound like an easy fix.
I'll wait till official support is added, until then your branch is running great for me

@jordanlambrecht
Copy link

@OwsleyJr, @sct any movement on this?

@Socialblurr
Copy link

+1 I just got into overseerr and I run 2 instances of Sonarr like several others so and I'm just not quite savvy enough to be able to modify my docker image of Overseerr to use this myself but if someone could help or this gets it's own docker image and tag that would be beautiful too

@miandru
Copy link

miandru commented Jun 24, 2024

This would solve my super jank solution! Please merge this @OwsleyJr
Currently I'm tagging all my anime requests in sonarr1 resulting in them not being able to use the trackers or download client. and then using import lists function on my anime instance to import the anime tagged with their tag. THIS WORKS, but it's super janky. This would be a much more preferable solution.

@actuallyevan
Copy link

This would be awesome if merged!!!!

engels74 added a commit to engels74/overseerr-anime that referenced this pull request Sep 18, 2024
@engels74
Copy link

engels74 commented Sep 18, 2024

Hey everyone.

For any of you who're still following this pull request, eagerly waiting for it to get merged, I went ahead and created a docker image with this PR included in it, based of the latest release as of this writing (v1.33.2).

It's based on hotio's docker container, and it auto updates and so on and so forth, like the rest of hotio's container images. So if you're familiar with his docker images, it should be a no-brainer to get it up and running. I added a small README to the page, that should explain the basics.

The Docker image can be found here:
https://github.com/engels74/overseerr-anime

I haven't tested it very extensively, but it should work, as it's based off of this PR. Be wary it might not work well with request-bots like requestrr and doplarr.

Kind regards,
engels74

@jordanlambrecht
Copy link

jordanlambrecht commented Nov 2, 2024

@sct @engels74 @OwsleyJr Any idea what else still needs to be done to get this merged? Happy to help out wherever needed.

@engels74
Copy link

engels74 commented Nov 2, 2024

@sct @engels74 @OwsleyJr Any idea what else still needs to be done to get this merged? Happy to help out wherever needed.

All maintainers are very busy, so it probably won't get merged in the near future 🙂

@actuallyevan
Copy link

actuallyevan commented Nov 2, 2024

@sct @engels74 @OwsleyJr Any idea what else still needs to be done to get this merged? Happy to help out wherever needed.

Just use @engels74's docker image, it's working great

@Dental1347
Copy link

Hey everyone.

For any of you who're still following this pull request, eagerly waiting for it to get merged, I went ahead and created a docker image with this PR included in it, based of the latest release as of this writing (v1.33.2).

It's based on hotio's docker container, and it auto updates and so on and so forth, like the rest of hotio's container images. So if you're familiar with his docker images, it should be a no-brainer to get it up and running. I added a small README to the page, that should explain the basics.

The Docker image can be found here: https://github.com/engels74/overseerr-anime

I haven't tested it very extensively, but it should work, as it's based off of this PR. Be wary it might not work well with request-bots like requestrr and doplarr.

Kind regards, engels74

Regarding the requestrr and doplarr bots, what could cause it to not work? Has this been tested?

Would love to use this, but I also make use of those two bots :)

@engels74
Copy link

Regarding the requestrr and doplarr bots, what could cause it to not work? Has this been tested?

Would love to use this, but I also make use of those two bots :)

I haven't tested it really, but looking through the file changes in this PR, you can see there's a new isAnime variable/function. Both requestrr and doplarr is not updated for this. And they probably won't be, until this PR has been merged into the official repository.

What this means in practice is that the bots will probably "work", until a user request an Anime series or movie. I'm not sure what will happen, but most likely it'll either error out, or place the Anime series or movie in an incorrect folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sonarr for anime only - remove requirement