Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move out sdtype validations from multi-column transformers #779

Merged
merged 8 commits into from
Apr 5, 2024
Merged

Move out sdtype validations from multi-column transformers #779

merged 8 commits into from
Apr 5, 2024

Conversation

R-Palazzo
Copy link
Contributor

CU-86azy5u67
Resolve #778

@R-Palazzo R-Palazzo requested review from amontanez24 and fealho April 3, 2024 15:29
@R-Palazzo R-Palazzo requested a review from a team as a code owner April 3, 2024 15:29
@sdv-team
Copy link
Contributor

sdv-team commented Apr 3, 2024

Task linked: CU-86azy5u67 RDT - Move out sdtype validations from multi-column transformers #778

@R-Palazzo R-Palazzo removed the request for review from a team April 3, 2024 15:30
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (03b96e9) to head (7d30316).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #779   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        17    +1     
  Lines         2044      2128   +84     
=========================================
+ Hits          2044      2128   +84

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

amontanez24
amontanez24 reviewed Apr 3, 2024
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but otherwise looks good! I just want to look at the corresponding SDV PR before appproving

rdt/transformers/_validations.py Outdated Show resolved Hide resolved
@R-Palazzo R-Palazzo requested a review from amontanez24 April 4, 2024 08:33
amontanez24
amontanez24 reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change is I would rename _validations -> _validators

@R-Palazzo R-Palazzo requested a review from amontanez24 April 4, 2024 16:28
amontanez24
amontanez24 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

fealho
fealho approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good 💯

@R-Palazzo R-Palazzo merged commit f330c6f into main Apr 5, 2024
45 checks passed
@R-Palazzo R-Palazzo deleted the issue-778-sdtype-validations-multi-column-transformer branch April 5, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fealho fealho fealho approved these changes

@amontanez24 amontanez24 amontanez24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move out sdtype validations from multi-column transformers
5 participants
@R-Palazzo @sdv-team @codecov-commenter @amontanez24 @fealho