Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DiagnosticReport to calculate base correctness of synthetic data #496

Merged
merged 7 commits into from
Nov 6, 2023

Conversation

R-Palazzo
Copy link
Contributor

CU-86aygcpga
Resolve #471

@R-Palazzo R-Palazzo requested a review from a team as a code owner November 3, 2023 22:15
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (383551b) 78.40% compared to head (6f13333) 78.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           diagnostic_report_updates     #496      +/-   ##
=============================================================
- Coverage                      78.40%   78.00%   -0.40%     
=============================================================
  Files                            103      102       -1     
  Lines                           3681     3615      -66     
=============================================================
- Hits                            2886     2820      -66     
  Misses                           795      795              
Files Coverage Δ
sdmetrics/reports/base_report.py 99.17% <100.00%> (-0.83%) ⬇️
sdmetrics/reports/multi_table/diagnostic_report.py 100.00% <100.00%> (ø)
sdmetrics/reports/multi_table/quality_report.py 100.00% <ø> (ø)
...dmetrics/reports/single_table/diagnostic_report.py 100.00% <100.00%> (ø)
sdmetrics/reports/single_table/quality_report.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@R-Palazzo R-Palazzo removed the request for review from a team November 6, 2023 14:43
Copy link
Contributor

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Base automatically changed from issue-469-relationshipvalidity-property to diagnostic_report_updates November 6, 2023 20:35
@R-Palazzo R-Palazzo force-pushed the issue-471-diagnostic-report branch from 4d8bfe1 to c566a75 Compare November 6, 2023 20:41
@R-Palazzo R-Palazzo force-pushed the diagnostic_report_updates branch from de9644f to 383551b Compare November 6, 2023 20:46
@R-Palazzo R-Palazzo force-pushed the issue-471-diagnostic-report branch from c566a75 to 6f13333 Compare November 6, 2023 20:51
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Glad we were able to reduce the code by so much

@R-Palazzo R-Palazzo merged commit 340b8fe into diagnostic_report_updates Nov 6, 2023
@R-Palazzo R-Palazzo deleted the issue-471-diagnostic-report branch November 6, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants