Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize sequential data with line plot #500

Merged
merged 8 commits into from
Nov 9, 2023

Conversation

lajohn4747
Copy link
Contributor

@lajohn4747 lajohn4747 commented Nov 7, 2023

CU-85ztcte5r

resolves #376

This PR adds the ability to generate a line graph for sequential data separated out by real and synthetic data. Able to graph against a single column and with the metadata, we can defined the x-axis and other sequences within our data. Multiple sequences will cause the graph to graph the average but show a range from min-max of the real/synthetic data.

Screenshot 2023-11-08 at 12 59 58 AM

@lajohn4747 lajohn4747 requested a review from a team as a code owner November 7, 2023 17:13
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (cea4dac) 76.99% compared to head (4cf1199) 77.12%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
+ Coverage   76.99%   77.12%   +0.13%     
==========================================
  Files          93       93              
  Lines        3442     3488      +46     
==========================================
+ Hits         2650     2690      +40     
- Misses        792      798       +6     
Files Coverage Δ
sdmetrics/reports/utils.py 86.59% <100.00%> (+0.28%) ⬆️
sdmetrics/visualization.py 92.26% <86.36%> (-1.74%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lajohn4747 lajohn4747 marked this pull request as draft November 7, 2023 18:26
@amontanez24
Copy link
Contributor

@lajohn4747 lajohn4747 requested a review from npatki November 8, 2023 07:20
@lajohn4747 lajohn4747 marked this pull request as ready for review November 8, 2023 07:22
@lajohn4747 lajohn4747 marked this pull request as draft November 8, 2023 15:26
@lajohn4747 lajohn4747 marked this pull request as ready for review November 8, 2023 15:55
Copy link
Contributor

@npatki npatki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor comments!

sdmetrics/visualization.py Show resolved Hide resolved
sdmetrics/visualization.py Show resolved Hide resolved
sdmetrics/visualization.py Outdated Show resolved Hide resolved
sdmetrics/visualization.py Outdated Show resolved Hide resolved
sdmetrics/visualization.py Outdated Show resolved Hide resolved
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sdmetrics/visualization.py Outdated Show resolved Hide resolved
tests/unit/test_visualization.py Outdated Show resolved Hide resolved
Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lajohn4747 lajohn4747 merged commit 87790f2 into main Nov 9, 2023
45 checks passed
@lajohn4747 lajohn4747 deleted the issue-376-visualize-sequential branch November 9, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add visualization for timeseries / sequential data
5 participants