feat: Add numba harmonic mean implementation #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added '_sv_harmon_mean' numba implementation for calculating harmonic mean that uses calculations used within the original fortran code to get same harmonic values. Now there's a 'method' value for the main 'sv_harmonic_mean' function that allows user to switch back and forth b/w the two methods. --- Ref #193
Separate out value testing for the two methods of computing harmonic mean. The fortran values are obtained from previous discussions at #66 (comment).
Add simple test for using the new '_sv_harmon_mean' function on dummy arrays.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
==========================================
- Coverage 50.98% 50.60% -0.38%
==========================================
Files 16 16
Lines 865 905 +40
==========================================
+ Hits 441 458 +17
- Misses 424 447 +23 ☔ View full report in Codecov by Sentry. |
Added a raise NotImplementedError for any other harmonic mean methods that is neither "scipy" nor "numba".
carlosgjs
approved these changes
Dec 2, 2023
lsetiawan
commented
Dec 4, 2023
lsetiawan
commented
Dec 4, 2023
Co-authored-by: carlosgjs <[email protected]>
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added '_sv_harmon_mean' numba implementation for
calculating harmonic mean that uses calculations
used within the original fortran code to get same
harmonic values. Now there's a 'method' value for the main 'sv_harmonic_mean' function that allows user
to switch back and forth b/w the two methods.
Ref #193