Add support for updating forge notifications when the counter changes #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's better add a hook, and let the users make the decision. |
|
Makes sense. Let me know if this works. |
qingshuizheng
pushed a commit
to qingshuizheng/doom-modeline
that referenced
this pull request
Dec 5, 2023
…seagle0128#680) * Add support for updating forge notifications when the counter changes * Switch to hook-based approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m not sure if there is interest in this functionality, but I thought it could be useful for those who use forge to check GitHub notifications. It modifies
doom-modeline--github-fetch-notificationsand adds a user option,doom-modeline-github-update-forge, such that when its value is non-nil, an update todoom-modeline--github-notification-numberwill trigger the fetching of notifications inforge. This ensures that the notification counter correctly reflects the number offorgeunread notifications, which may otherwise diverge.I’m relatively new to programming and Elisp specifically, so feel free to reject or suggest revisions.