Add support for display icons in check-simple-format #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seagle0128
requested changes
Mar 20, 2024
seagle0128
requested changes
Mar 20, 2024
seagle0128
added a commit
that referenced
this pull request
Mar 24, 2024
This reverts commit 798d8b9.
|
I took a look into this PR this weekend, and realized the implement was not right. The icons are displayed incorrectly in inactive windows and during refreshing. I decided to revert all commits. |
I have noticed that too, I will try to improve and fix this implementation next time. |
DevelopmentCool2449
added a commit
to DevelopmentCool2449/doom-modeline
that referenced
this pull request
Mar 24, 2024
This a improved version of this PR seagle0128#706, this should fix some bugs from original patch like icons in inactive window and a better look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add an optional feature to include icons to check-simple-format, it makes doom-modeline fancy and easier to distinguish error types (related to: #639), this implementation no needs to force users add-advices or make a custom (and more complex) segment to modeline.
I would like hear their suggest about this.