Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 放开制卡上限轮数上限的限制, 并允许drl new创建大于轮数上限的骰池 #365

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

Xiangze-Li
Copy link
Member

Close #301

也修改了若干处 CmdExecuteResultSolved 字段, 从 false 改为 true. 这是因为, false会在日志里留下"忽略指令"记录, 这是不符合实际情况的.

@Xiangze-Li Xiangze-Li requested review from fy0 and oissevalt October 23, 2023 10:21
@Xiangze-Li Xiangze-Li self-assigned this Oct 23, 2023
@oissevalt
Copy link
Contributor

看着似乎可以,但WebUI那边需不需要配套的改动(无效值当场跳出警告之类的)?

@fy0 fy0 merged commit e7ba6fb into sealdice:master Oct 23, 2023
@fy0
Copy link
Member

fy0 commented Oct 23, 2023

看着似乎可以,但WebUI那边需不需要配套的改动(无效值当场跳出警告之类的)?

当然需要,dice里多加了几个选项

坏了 想起上一个PR我就忘了加

@Xiangze-Li Xiangze-Li deleted the 301-unify-max-rolltime branch October 23, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discussion] 关于coc制卡数量上限和骰点轮数上限
3 participants