Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: 升级 go version 至 1.20，并同步调整相关代码 #397

Merged
merged 9 commits into from
Nov 13, 2023
Merged

build: 升级 go version 至 1.20，并同步调整相关代码 #397

merged 9 commits into from
Nov 13, 2023

Conversation

JustAnotherID
Copy link
Collaborator

No description provided.

@JustAnotherID JustAnotherID requested review from fy0, Xiangze-Li and Szzrain and removed request for fy0 and Xiangze-Li November 9, 2023 08:10
Xiangze-Li
Xiangze-Li approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@Xiangze-Li Xiangze-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 不过还需要确认一下各种平台的兼容性, 尤其是亲爱的 CentOS 7

.github/workflows/test_and_lint.yml Outdated Show resolved Hide resolved
@Xiangze-Li
Copy link
Member

Xiangze-Li commented Nov 9, 2023 •
edited
Loading

我记得我之前写哪里的时候, 曾经想用 19 和 20 的函数来着, 既然升级到 21 了, 应该改改去

dice/dice_backup.go:268, 用注释掉的代码替换现有的代码即可.

Szzrain
Szzrain approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@Szzrain Szzrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

希望Go 1.21 有内建的针对安卓DNS的修复吧，不然还需要回滚此pr

@JustAnotherID
Copy link
Collaborator Author

希望Go 1.21 有内建的针对安卓DNS的修复吧，不然还需要回滚此pr

目前的代码好像并没有对 SetDefaultNS 的使用，这一块看上去似乎是历史代码？因为 //go:linkname 不再支持这么使用导致报错的问题，先把这块去掉了

@JustAnotherID JustAnotherID requested a review from Szzrain November 9, 2023 10:05
@JustAnotherID
Copy link
Collaborator Author

我记得我之前写哪里的时候, 曾经想用 19 和 20 的函数来着, 既然升级到 21 了, 应该改改去

dice/dice_backup.go:268, 用注释掉的代码替换现有的代码即可.

这个一起调整了

@Xiangze-Li
Copy link
Member

或许可以先压一下, 等 1.4.1 发完再做这个变更?

这样至少不会有啥问题一下炸到外面去.

@JustAnotherID
Copy link
Collaborator Author

或许可以先压一下, 等 1.4.1 发完再做这个变更?

这样至少不会有啥问题一下炸到外面去.

合理，那放 1.4.2 版本里吧，这个先暂缓合并

@JustAnotherID JustAnotherID marked this pull request as draft November 9, 2023 10:25
@JustAnotherID JustAnotherID marked this pull request as ready for review November 10, 2023 15:44
@fy0
Copy link
Member

fy0 commented Nov 11, 2023

很难受，希望gopherjs能够给力一点，至今还在1.18
直接编译到wasm的支持状态也是一坨，官方给点力啊！！

@JustAnotherID JustAnotherID changed the title build: 升级 go version 至 1.21，并同步调整相关代码 build: 升级 go version 至 1.20，并同步调整相关代码 Nov 11, 2023
@JustAnotherID
Copy link
Collaborator Author

go 1.21 放弃了 win7 支持，先降回 1.20 （悲

@fy0 fy0 merged commit 8a8b59e into sealdice:master Nov 13, 2023
@JustAnotherID JustAnotherID deleted the feature/upgrade-go-version branch November 13, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fy0 fy0 Awaiting requested review from fy0

@Xiangze-Li Xiangze-Li Awaiting requested review from Xiangze-Li

@Szzrain Szzrain Awaiting requested review from Szzrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JustAnotherID @Xiangze-Li @fy0 @Szzrain