Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 给戳一戳功能增加提示信息 #225

Merged
merged 2 commits into from
Jul 20, 2024
Merged

feat: 给戳一戳功能增加提示信息 #225

merged 2 commits into from
Jul 20, 2024

Conversation

JustAnotherID
Copy link
Contributor

7cb5e90698f472f0abd5c69c99a0bfaa
68a6e1b14957c87a64e80792e4b3b33d

@MintCider
Copy link
Collaborator

听说 Lagrange 那边跟进了戳一戳功能？或许可以先等一个明确的结论？

@JustAnotherID
Copy link
Contributor Author

听说 Lagrange 那边跟进了戳一戳功能？或许可以先等一个明确的结论？

就是因为更新了才调整成现在的提示语。

MintCider
MintCider previously approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@MintCider MintCider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外或许可以给出

例如：Lagrange >= <version number>

这样的信息？（不给也行

src/components/misc/PageMiscSettings.vue Outdated Show resolved Hide resolved
@JustAnotherID JustAnotherID requested a review from MintCider July 20, 2024 11:17
@JustAnotherID
Copy link
Contributor Author

JustAnotherID commented Jul 20, 2024 •
edited
Loading

另外或许可以给出

例如：Lagrange >=

这样的信息？（不给也行

Lagrange 现在应该只有 git hash，没法提示（

以及其他对接可能也有支持，我们就不在 UI 上做更细节的提示了。

@JustAnotherID JustAnotherID merged commit dcef6f6 into sealdice:master Jul 20, 2024
1 check passed
@JustAnotherID JustAnotherID deleted the feat/poke-warning branch July 20, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MintCider MintCider MintCider approved these changes

@fy0 fy0 Awaiting requested review from fy0

@Xiangze-Li Xiangze-Li Awaiting requested review from Xiangze-Li

@Szzrain Szzrain Awaiting requested review from Szzrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JustAnotherID @MintCider