performance: GetMonthDay re-implemented using most faster algorithm (without cycle) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebres
pushed a commit
that referenced
this pull request
Sep 14, 2021
* Add a --with-tzpath configure flag * Fix unwanted stateful behavior when /etc/localtime does not exist
sebres
pushed a commit
that referenced
this pull request
Sep 14, 2021
Fix configure error introduced in #5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just as quick performance fix as suggested from @martinwguy in flightaware/Tcl-bounties#4 (comment) (but without usage of suggested "Algorithm 199")...
The algorithm is pretty easy:
estimate month by calculating
dayOfYear / (365/12), then do forwards/backwards correction (dummy cycle - it repeats maximum once).