-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use an exact match for backwards-compatible-json. #8
Conversation
Thanks, Mark! I think we should use a different domain than |
Do you have a suggestion for what domain to use? Alternatively, if there is no natural domain to use, we could go back to the non-URI string to avoid the issue. |
|
Previously the doc said it was a prefix match, but that is both error-prone and slightly complex. It is safer and easier to use an exact string match. We use a magic URI so that it may optionally serve documentation for this format. Also add a warning that backwards compatibility should be disabled by default.
Hmm, that doesn't indicate that it's specific to backwards compatibility with in-toto and TUF. What do you think about avoiding magic "payloadType" altogether and instead having an explicit "mode" field? That would sidestep the question and hopefully be more explicit. Something like:
I'll send out an update so we can see what that looks like. |
That's why I was thinking of using the secure systems lab domain |
That sounds good to me. :) |
Yes, we really should move our canonical JSON code to its own github repo, like Docker did for its own implementation. Leaves things super unambiguous. |
I like the idea. We could also just write down a small readme file describing how we differentiate (disambiguate stuff from?) OLPC |
I put together a draft version that does away with the magic URI, replacing it with an explicit If you get a chance, please take a look to let me know what you think. If you all think it's a good idea, I'll update this PR to go that route instead. |
I don't feel strongly either way, so would you please briefly describe pros vs cons of each? |
Benefits of
Benefits magic
|
Thanks for the enumeration, Mark! Let me sleep on this (it's 3AM here) and get back to you, please... |
I'm personally leaning towards the first option... |
Closed in favour of #13. |
Previously the doc said it was a prefix match, but that is both error-prone and slightly complex. It is safer and easier to use an exact string match. We use a magic URI so that it may optionally serve documentation for this format.
Also add a warning that backwards compatibility should be disabled by default.
Closes #5.