Move VideoCallClient into its own crate
#142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… callback hell With some code cleanups along the way
Conform `use` statements in yew-ui to crate
|
Ok, I'll take a look, thanks for this huge contribution @ronen !! |
|
@ronen @griffobeid I think that you guys should talk about #144 |
griffobeid
approved these changes
Oct 4, 2023
|
|
||
| --- | ||
|
|
||
| This crate provides a client-side (browser) interface to the videocall protocol. The purpose is to |
There was a problem hiding this comment.
We could be more specific here and say that it only supports Chrome due to some web APIs we use at the moment
There was a problem hiding this comment.
Yeah, good point. Added.
darioalessandro
added a commit
that referenced
this pull request
Nov 18, 2023
This reverts commit 8ece33d.
darioalessandro
added a commit
that referenced
this pull request
Nov 18, 2023
This reverts commit 8ece33d.
darioalessandro
added a commit
that referenced
this pull request
Nov 18, 2023
…)" This reverts commit 672a732.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #137. It's the same code, but takes it to the next step: Crate-ified the
VideoCallClientstuff: Moved all the code fromyew-ui/src/modelinto a new top-level workspace & cratevideocall-client. And added documentation! And of course also conformedyew-uito use the new crate.For ease of seeing what's going on here, I've based this PR off the
clientbranch. Dunno whether you'd want to merge this onto that branch for merging as part of #137, or I can change this to be based off main and merging this would supercede #137, or wait until #137 is merged on its own then I can rebase all this off ofmainand update this PR. I have no strong opinions. But it's done and working so figured I'd put it out for eyeballs now :)