Add proving schemes state to pubkey module #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacheigriega
force-pushed
the
hy/batch-boot
branch
2 times, most recently
from
2a95404 to
dc5f3da
Compare
hacheigriega
force-pushed
the
hy/batch-boot
branch
from
e48ead8 to
2b7858c
Compare
Thomasvdam
reviewed
Nov 30, 2024
Thomasvdam
reviewed
Dec 3, 2024
Thomasvdam
approved these changes
Dec 3, 2024
mariocao
reviewed
Dec 4, 2024
mariocao
reviewed
Dec 4, 2024
mariocao
reviewed
Dec 4, 2024
mariocao
reviewed
Dec 4, 2024
Thomasvdam
force-pushed
the
hy/batch-boot
branch
from
510cda7 to
c8ee8ce
Compare
hacheigriega
commented
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Changes
The public key end blocker now checks the percentage of validators that have registered the secp256k1 public key on chain. If this check passes the 80% threshold, the activation height of the proving scheme is set to
ActivationLagblocks after the block at which the threshold is reached. When the activation height is reached, the proving scheme is set to active status and all validators without the required public key gets jailed.This activation height is set to -1 by default to signify that activation process is not in progress. Also note that if the public key registration rate goes below the 80% threshold after an activation process begins (due to a new validator without the required key joining with substantial voting power), the activation height is reverted to -1.
For testing convenience, this
ActivationLagis currently set to a small number, 25. This value is a parameter that is subject to change through governance process.Batching is skipped until the secp256k1 proving scheme is activated.
Testing
Added simple unit tests but jailing is not tested yet.
Tested activation process & cancellation of activation process on a local multi-node network.
Closes: #421