Make dr block height part of the primary key #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomasvdam
force-pushed
the
feat/query-result-dr-height
branch
from
6f5d1eb to
4108502
Compare
hacheigriega
reviewed
Dec 2, 2024
hacheigriega
reviewed
Dec 2, 2024
This allows us to keep old results around for recurring data request IDs. Also introduces a few missing genesis states during initialisation.
Thomasvdam
force-pushed
the
feat/query-result-dr-height
branch
from
4108502 to
6a1ea9a
Compare
hacheigriega
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This allows us to keep old results around for recurring data request IDs.
Explanation of Changes
We don't need a latest batch assignment query since those should always uniquely identify the exact DR_ID+height combination for which the result has been batched.
We have to manually create a range since the built in
collections.NewSuperPrefixedTripleRangedoesn't expose the ordering methods despite them being present on the struct. :( Ver sad.Also introduces a few missing genesis states during initialisation.
Testing
Expanded on the result inclusion test to verify that you get the latest result when you do not specify the height, but by specifying the height you can still retrieve an older result. This also brought up the issue that by default the ordering of a Range is ascending.
Related PRs and Issues
N.A.