-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: params query #433
feat: params query #433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for the other protobuf changes, I'm not sure why the make proto-all command was removing the 1 line from a few files.
Last time we had this is was because we were using different versions of the proto toolchain. I'm using buf 1.47.2
@Thomasvdam I updated my buf version to match yours, but it seems those 1 line changes remain the same. |
That's odd, when I run it on your branch it adds all the lines back. Are you sure the shell session executing the |
I'm using the |
8551abf
to
5e7e9f8
Compare
@Thomasvdam and I learned I had to do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops
Motivation
Seems that most built in modules support querying the params from GRPC/CLI.
This would make my life much easier on the test suite side as well.
Explanation of Changes
I added a new
Params
query to the pubkey module, matching how other sdk modules add theparams
query.I also added the CLI/Go code to support the above.
As for the other protobuf changes, I'm not sure why the
make proto-all
command was removing the 1 line from a few files.Currently branch is based on
main
, if it's a pain I can re-base and target #431 instead @hacheigriega?Testing
Tested with test suite.
Should I somehow add other tests?
Related PRs and Issues
N/A