Feat: proto common #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomasvdam
reviewed
Oct 8, 2024
gluax
force-pushed
the
feat/proto-common
branch
from
079839a to
8229685
Compare
gluax
force-pushed
the
feat/proto-common
branch
from
e5f1687 to
5115f42
Compare
gluax
force-pushed
the
feat/proto-common
branch
from
5115f42 to
b362c84
Compare
Thomasvdam
approved these changes
Oct 10, 2024
mariocao
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To have the protobuf in a shared repo.
Explanation of Changes
Creates a workspace.
Moves the
seda-commonto a workspace member.Creates a new
seda-proto-commonas a workspace member.Testing
Works in the test suite using the same versions as
devnet, which uses both.Need to update the overlay yet.
Related PRs and Issues
N/A