Handle missing layers #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seddonym
force-pushed
the
handle-missing-layers
branch
from
d89c764 to
44ca8e6
Compare
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
=======================================
Coverage 90.08% 90.08%
=======================================
Files 11 11
Lines 565 565
=======================================
Hits 509 509
Misses 56 56Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tackles #69.
Layer Linter will now error if a layer could not be found. On balance I think this is more important than allowing optional layers, as this seems to trip people up when starting. A future feature could perhaps allow optional layers to be listed in parentheses in the
layers.yml.