Migrate Config #131
Merged
Migrate Config #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samchungy
commented
Oct 16, 2024
default.json
Outdated
There was a problem hiding this comment.
Changes from: samchungy/renovate-experiments@a0d6126
non-critical.json
Outdated
There was a problem hiding this comment.
Changes from: samchungy/renovate-experiments@c2e0251
There was a problem hiding this comment.
Changes from: samchungy/renovate-experiments@a0d6126
72636c
reviewed
Oct 17, 2024
| @@ -83,7 +94,7 @@ | |||
| "minimumReleaseAge": "14 days" | |||
| }, | |||
| { | |||
| "excludePackagePatterns": ["^seek-jobs/", "^seek-oss/"], | |||
| "matchPackageNames": ["!/^seek-jobs//", "!/^seek-oss//"], | |||
There was a problem hiding this comment.
Do the slashes here need to be escaped?
https://docs.renovatebot.com/string-pattern-matching/#use-regex101-to-test-your-patterns
There was a problem hiding this comment.
Renovate migrate did that 😅
Comment on lines
+80
to
+81
| "!/^@?seek/", | ||
| "!/seek$/" |
There was a problem hiding this comment.
Existing issues, but should we
- Enforce
@seek/rather than@seek - Drop the dubious
seeksuffix one and instead allowlist specific packages that we trust
72636c
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy 🍝'ed changes from: https://github.com/samchungy/renovate-experiments
configMigration: trueis part of the recommended config: https://docs.renovatebot.com/upgrade-best-practices/#whats-in-the-configbest-practices-preset.