Align validation messages with recommendations (#896)

* Remove pleases * Add changeset
seek-oss · Mar 3, 2023 · 4757b44 · 4757b44
1 parent 3f8185c
commit 4757b44
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 11 deletions.
diff --git a/.changeset/tame-cycles-leave.md b/.changeset/tame-cycles-leave.md
@@ -0,0 +1,5 @@
+---
+'wingman-fe': patch
+---
+
+Align validation messaging with recommendations
diff --git a/fe/lib/components/JobCategorySelect/JobCategorySelect.stories.tsx b/fe/lib/components/JobCategorySelect/JobCategorySelect.stories.tsx
@@ -26,7 +26,7 @@ export default {
     braidThemeName: defaultArgTypes.braidThemeName,
     message: {
       control: { type: 'radio' },
-      mapping: { undefined, requiredValidation: 'Please select a category.' },
+      mapping: { undefined, requiredValidation: 'Select a category' },
       options: ['undefined', 'requiredValidation'],
     },
     showStorybookAction: defaultArgTypes.showStorybookAction,

diff --git a/fe/lib/components/JobCategorySuggest/JobCategorySuggest.stories.tsx b/fe/lib/components/JobCategorySuggest/JobCategorySuggest.stories.tsx
@@ -30,7 +30,7 @@ export default {
     braidThemeName: defaultArgTypes.braidThemeName,
     message: {
       control: { type: 'radio' },
-      mapping: { undefined, requiredValidation: 'Please select a category.' },
+      mapping: { undefined, requiredValidation: 'Select a category' },
       options: ['undefined', 'requiredValidation'],
     },
     showStorybookAction: defaultArgTypes.showStorybookAction,

diff --git a/fe/lib/components/LocationSuggest/LocationSuggest.stories.tsx b/fe/lib/components/LocationSuggest/LocationSuggest.stories.tsx
@@ -27,7 +27,7 @@ export default {
     braidThemeName: defaultArgTypes.braidThemeName,
     message: {
       control: { type: 'radio' },
-      mapping: { undefined, requiredValidation: 'Please select a location.' },
+      mapping: { undefined, requiredValidation: 'Select a location' },
       options: ['undefined', 'requiredValidation'],
     },
     showStorybookAction: defaultArgTypes.showStorybookAction,

diff --git a/...estionnaireBuilder/FormBuilder/components/NewPrivacyConsentForm/NewPrivacyConsentForm.tsx b/...estionnaireBuilder/FormBuilder/components/NewPrivacyConsentForm/NewPrivacyConsentForm.tsx
@@ -47,14 +47,14 @@ const resolver = createResolver<FormValues>((values, errors) => {
   if (!values.description.trim()) {
     errors.description = {
       type: 'required',
-      message: 'Please enter a description.',
+      message: 'Enter a description',
     };
   }
 
   if (!isWebUrl(values.url)) {
     errors.url = {
       type: 'validate',
-      message: 'Please enter a valid HTTP(S) URL.',
+      message: 'Enter a valid HTTP(S) URL',
     };
   }
 });

diff --git a/...omponents/QuestionnaireBuilder/FormBuilder/components/NewQuestionForm/NewQuestionForm.tsx b/...omponents/QuestionnaireBuilder/FormBuilder/components/NewQuestionForm/NewQuestionForm.tsx
@@ -36,30 +36,30 @@ const resolver = createResolver<FormValues>((values, errors) => {
   if (!values.questionType) {
     errors.questionType = {
       type: 'required',
-      message: 'Please select a question type.',
+      message: 'Select a question type',
     };
   } else if (
     values.questionType === 'FreeText' &&
     values.responseChoice?.length
   ) {
     errors.questionType = {
       type: 'validate',
-      message: 'Please omit any response options.',
+      message: 'Omit any response options',
     };
   } else if (
     values.questionType !== 'FreeText' &&
     (!values.responseChoice || values.responseChoice.length < 2)
   ) {
     errors.questionType = {
       type: 'validate',
-      message: 'Please provide at least two response options.',
+      message: 'Provide at least two response options',
     };
   }
 
   if (!values.questionHtml) {
     errors.questionHtml = {
       type: 'required',
-      message: 'Please enter a question.',
+      message: 'Enter a question',
     };
   }
 });

diff --git a/.../QuestionnaireBuilder/FormBuilder/components/NewQuestionForm/components/SelectOptions.tsx b/.../QuestionnaireBuilder/FormBuilder/components/NewQuestionForm/components/SelectOptions.tsx
@@ -44,12 +44,12 @@ export default ({ options, setOptionList }: SelectOptionsProps) => {
         if (!values.option) {
           errors.option = {
             type: 'required',
-            message: 'Please enter an option.',
+            message: 'Enter an option',
           };
         } else if (options.some((option) => option.value === values.option)) {
           errors.option = {
             type: 'validate',
-            message: 'This option already exists.',
+            message: 'This option already exists',
           };
         }
       }),