Issue 1147 fix cv duplication in template json import #2104

kdp-cloud · 2025-01-08T09:24:08Z

Reuses Controlled vocabularies instead of creating duplicates every time a new instance-wide template is uploaded.
Add control of the allow_cv_free_text attribute in template attributes.
Closes CV title #1147

A before_action :is_user_admin_auth already prevents the method to be reached by non-admin users.

Reuse the Sample Attribute types if they already exist instead of creating a new one for every test.

stuzart

Approved, but with a couple of comments

lib/seek/isa_templates/template_attributes_schema_test.json

lib/seek/isa_templates/template_attributes_schema.json

kdp-cloud added 9 commits January 7, 2025 12:00

Add user authentication

f9c9254

remove unnecessary guard clause

052e661

A before_action :is_user_admin_auth already prevents the method to be reached by non-admin users.

Make the uploaded template reuse the controlled vocabulary

251d8c7

Make it work for ontologies as well

0584b67

Make it work for CV Lists

fe7fb86

Fix tests

299583b

Reuse the Sample Attribute types if they already exist instead of creating a new one for every test.

Add possibility to control define whether a CV allows free text

1b2813a

Reformat

e8787e5

Testing

14764da

kdp-cloud marked this pull request as draft January 8, 2025 09:53

kdp-cloud added 2 commits January 8, 2025 11:51

Better error handling when failing to fetch terms from OLS

b9a3252

Fix failing job test

21f1e53

kdp-cloud marked this pull request as ready for review January 8, 2025 11:47

stuzart approved these changes Jan 8, 2025

View reviewed changes

lib/seek/isa_templates/template_attributes_schema_test.json Show resolved Hide resolved

lib/seek/isa_templates/template_attributes_schema.json Show resolved Hide resolved

kdp-cloud mentioned this pull request Jan 8, 2025

Harmonize JSON schemas for instance-wide template upload #2108

Open

kdp-cloud merged commit cd05bbf into seek4science:seek-1.16 Jan 8, 2025
10 checks passed

kdp-cloud deleted the issue-1147-fix-cv-duplication-in-template-json-import branch January 8, 2025 17:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 1147 fix cv duplication in template json import #2104

Issue 1147 fix cv duplication in template json import #2104

kdp-cloud commented Jan 8, 2025

stuzart left a comment

Issue 1147 fix cv duplication in template json import #2104

Issue 1147 fix cv duplication in template json import #2104

Conversation

kdp-cloud commented Jan 8, 2025

stuzart left a comment

Choose a reason for hiding this comment