Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STRATCONN-5380] - Fix google enhanced conversion error parsing #2705

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

varadarajan-tw
Copy link
Contributor

@varadarajan-tw varadarajan-tw commented Jan 24, 2025

This PR fixes HTTP error parsing foruserList for Google Enhanced Conversions destination.

This PR solves two key issues

  • Internal Error due to incorrect response structure parsing
  • Handles concurrent modification error and rethrows it as retryable error for all APIs used in userList action. It seems like all APIs createOfflineJob, addOpertions and run (less likely) can throw this exception. (Previous PR)

More on before and after state in Test Doc

This destination could benefit from Multistatus. I'll try to implement it in a different PR.

Testing

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@varadarajan-tw varadarajan-tw changed the title Fix google enhanced conversion error parsing [STRATCONN-5380] - Fix google enhanced conversion error parsing Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant