Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make SegmentInstant thread safe #207

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

wenxi-zeng
Copy link
Contributor

@wenxi-zeng wenxi-zeng commented Dec 5, 2023

addressed threat safety concern mentioned in #200

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fedb363) 83.61% compared to head (55d45bd) 78.54%.
Report is 1 commits behind head on main.

Files Patch % Lines
...t/analytics/kotlin/core/utilities/DateTimeUtils.kt 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #207      +/-   ##
============================================
- Coverage     83.61%   78.54%   -5.08%     
  Complexity      495      495              
============================================
  Files            70       78       +8     
  Lines          5713     6586     +873     
  Branches        747      833      +86     
============================================
+ Hits           4777     5173     +396     
- Misses          298      739     +441     
- Partials        638      674      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wenxi-zeng wenxi-zeng merged commit 416edf5 into main Dec 6, 2023
7 checks passed
@wenxi-zeng wenxi-zeng deleted the wenxi/thread-safety-timestamp branch December 6, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants