Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fetch priority and headers configurable, and define types for segment.io and integration options. #1204

Merged
merged 12 commits into from
Jan 21, 2025
Merged

Make fetch priority and headers configurable, and define types for segment.io and integration options. #1204

merged 12 commits into from
Jan 21, 2025

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Dec 18, 2024 •
edited
Loading

Addresses:

  1. Fetch Priority - Feature request: Add support to configure fetch priority for the network calls #1199
  2. Headers - Make HTTP headers configurable #392
  3. Add typings to Segment.io config type safe (w/ autocomplete -- this is a super complicated object, so self-documention = less support).
image

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 4f44fa4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@segment/analytics-next Minor
@segment/analytics-consent-tools Patch
@segment/analytics-signals Patch
@segment/analytics-consent-wrapper-onetrust Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@silesky silesky marked this pull request as ready for review December 19, 2024 18:19
@silesky silesky force-pushed the make-fetch-priority-and-headers-configurable branch from ce7f6da to d912dcc Compare January 20, 2025 21:12
@silesky silesky changed the title make fetch priority and headers configurable Make fetch priority and headers configurable, and make segment.io config type-safe. Jan 20, 2025
@silesky silesky changed the title Make fetch priority and headers configurable, and make segment.io config type-safe. Make fetch priority and headers configurable, and define types for segment.io and integration options. Jan 20, 2025
@silesky silesky force-pushed the make-fetch-priority-and-headers-configurable branch from f556cc0 to e960708 Compare January 20, 2025 22:12
@silesky silesky requested a review from alanjcharles January 21, 2025 17:19
@silesky silesky merged commit 8e0162b into master Jan 21, 2025
8 checks passed
@silesky silesky deleted the make-fetch-priority-and-headers-configurable branch January 21, 2025 19:35
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanjcharles alanjcharles alanjcharles approved these changes

@danieljackins danieljackins Awaiting requested review from danieljackins

@MichaelGHSeg MichaelGHSeg Awaiting requested review from MichaelGHSeg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silesky @alanjcharles