Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary sleep #1247

Merged
merged 2 commits into from
Nov 30, 2023
Merged

remove unnecessary sleep #1247

merged 2 commits into from
Nov 30, 2023

Conversation

tigercosmos
Copy link
Collaborator

@tigercosmos tigercosmos commented Nov 29, 2023

fixed #1246

it's unnecessary to use sleep.

@tigercosmos tigercosmos requested a review from seladb as a code owner November 29, 2023 11:31
@tigercosmos
Copy link
Collaborator Author

@seladb How to run the full tests? don't know why CI only runs 5 tests. As long as all tests pass. we should remove the sleep

@tigercosmos tigercosmos changed the base branch from master to dev November 29, 2023 12:05
@seladb
Copy link
Owner

seladb commented Nov 29, 2023

@seladb How to run the full tests? don't know why CI only runs 5 tests. As long as all tests pass. we should remove the sleep

@tigercosmos I think this is because you originally opened a PR to be merged to master instead of dev. If you choose dev when opening the PR it should run all CI checks.
What you can do now it add an empty commit to re-trigger CI:

git commit --allow-empty -m "Trigger CI"

(and then git push...)

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d04e18) 82.72% compared to head (9e72cc8) 82.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1247      +/-   ##
==========================================
- Coverage   82.72%   82.70%   -0.03%     
==========================================
  Files         159      159              
  Lines       20404    20403       -1     
  Branches     7711     7711              
==========================================
- Hits        16880    16875       -5     
- Misses       2902     2906       +4     
  Partials      622      622              
Flag Coverage Δ
alpine317 72.31% <ø> (-0.01%) ⬇️
centos7 74.41% <ø> (-0.01%) ⬇️
fedora37 72.32% <ø> (-0.01%) ⬇️
macos-11 61.28% <ø> (-0.01%) ⬇️
macos-12 61.33% <ø> (-0.01%) ⬇️
macos-ventura 61.31% <ø> (-0.01%) ⬇️
mingw32 70.20% <ø> (-0.02%) ⬇️
mingw64 70.19% <ø> (-0.05%) ⬇️
npcap 83.23% <ø> (-0.05%) ⬇️
ubuntu1804 74.88% <ø> (+0.01%) ⬆️
ubuntu2004 73.10% <ø> (-0.01%) ⬇️
ubuntu2204 72.16% <ø> (-0.01%) ⬇️
ubuntu2204-icpx 59.20% <ø> (-0.05%) ⬇️
unittest 82.70% <ø> (-0.03%) ⬇️
windows-2019 83.27% <ø> (-0.02%) ⬇️
windows-2022 83.28% <ø> (-0.02%) ⬇️
winpcap 83.26% <ø> (-0.01%) ⬇️
xdp ∅ <ø> (∅)
zstd 73.66% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seladb seladb merged commit 048cc9b into seladb:dev Nov 30, 2023
39 checks passed
@tigercosmos tigercosmos deleted the stopTime branch November 30, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants