Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump clang-format to 19.1.6 #1677

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Conversation

egecetin
Copy link
Collaborator

@egecetin egecetin commented Jan 4, 2025

Bumping version of clang-format to 19+ fixes weird formatting issue for struct initialization,

Before 19.x.x

struct abcd
{
};

After,

struct abcd{};

@egecetin egecetin requested a review from seladb as a code owner January 4, 2025 07:42
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.15%. Comparing base (7898a5d) to head (fd720f9).

Files with missing lines Patch % Lines
Packet++/src/VrrpLayer.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1677      +/-   ##
==========================================
- Coverage   83.16%   83.15%   -0.02%     
==========================================
  Files         277      277              
  Lines       48201    48201              
  Branches     9932     9946      +14     
==========================================
- Hits        40086    40081       -5     
+ Misses       7266     7229      -37     
- Partials      849      891      +42     
Flag Coverage Δ
alpine320 75.16% <50.00%> (+<0.01%) ⬆️
fedora40 75.17% <50.00%> (+<0.01%) ⬆️
macos-13 80.65% <50.00%> (ø)
macos-14 80.65% <50.00%> (-0.01%) ⬇️
macos-15 80.63% <50.00%> (ø)
mingw32 70.87% <50.00%> (-0.05%) ⬇️
mingw64 70.84% <50.00%> (-0.05%) ⬇️
npcap 85.30% <50.00%> (-0.02%) ⬇️
rhel94 75.03% <50.00%> (+<0.01%) ⬆️
ubuntu2004 58.60% <50.00%> (-0.03%) ⬇️
ubuntu2004-zstd 58.73% <50.00%> (ø)
ubuntu2204 74.94% <50.00%> (-0.04%) ⬇️
ubuntu2204-icpx 61.39% <50.00%> (-0.05%) ⬇️
ubuntu2404 75.20% <50.00%> (-0.03%) ⬇️
unittest 83.15% <50.00%> (-0.02%) ⬇️
windows-2019 85.33% <50.00%> (-0.01%) ⬇️
windows-2022 85.36% <50.00%> (-0.01%) ⬇️
winpcap 85.33% <50.00%> (ø)
xdp 50.53% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@seladb seladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@egecetin please update the clang-format version mentioned in CONTRIBUTING.md?

@egecetin egecetin requested a review from seladb January 9, 2025 16:20
@seladb seladb merged commit 78b629f into seladb:dev Jan 10, 2025
39 of 40 checks passed
@egecetin egecetin deleted the clang-format-version branch January 12, 2025 18:18
cla7aye15I4nd pushed a commit to aled-ua/PcapPlusPlus that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants