Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UIK-2988] Start/stop button and notification in SpinContainer, Spin, Skeleton examples #1914

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sheila-semrush
Copy link
Contributor

@sheila-semrush sheila-semrush commented Jan 9, 2025

Motivation and Context

Added start/stop button to examples of Spin, Skeleton, SpinContainer, instead of constant automatic switching.
Also added live messages on loading start/stop wherever needed.

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly or it's not required.
  • Unit tests are not broken.
  • I have added changelog note to corresponding CHANGELOG.md file with planned publish date.
  • I have added new unit tests on added of fixed functionality.

@sheila-semrush sheila-semrush marked this pull request as draft January 9, 2025 19:48
@sheila-semrush sheila-semrush marked this pull request as ready for review January 9, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant