-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UIK-2755][website] Headings and labels #1916
Conversation
Made two small updates based on our discussion on KB:
Also updated Pagination documentation for the other task to avoid conflicts in the structure. |
@j-mnizhek added my own commit to avoid posting a bunch of suggestions, I've shortened some long 2nd level headings and unified example headings a bit, feel free to add or edit over it |
Decided to move all the things related to appearance under the Appearance section, so that in the future we wouldn’t have to think much when we should put sizes, types, and topics outside of it, and where we shouldn’t. |
Co-authored-by: Sheila <[email protected]> Signed-off-by: Julia Mnizhek <[email protected]>
@sheila-semrush Made small updates, added missed Appearance headings, fixed dead link (it's strange that only one was found). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@j-mnizhek looks good to me!
You can also look at my last commit, I thought we need to fix the heading structure in our README/CONTRIBUTING files, so that the overall structure is correct when you view them on Github. Feel free to edit If you have any suggestions.
Motivation and Context
This PR introduces changes to the headings in our documentation to conform to the '2.4.6 Headings and Labels' criterion.
I ignored a couple of suggestions from the vale since they are not applicable for some of the changes.
How has this been tested?
Manually.
Types of changes
Checklist:
CHANGELOG.md
file with planned publish date.