Improve jruby support of ComplexFields #185
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to underlying differences in the jruby and MRI xml libraries in nokogiri, sablon doesn't currently work well in jruby. This PR improves the situation by fixing the ComplexField class in mail_merge.rb.
Currently the ComplexField class contains xpath searches that use namespace prefixed attributes in the search expression, which appears to not work in all cases with jruby/nokogiri. Using local-name and ignoring the attribute namespace prefix appears to work well for both jruby and MRI.
With this change, many of the test documents in 'test/sandbox/' appear to be generated correctly, even though tests continue to fail due to minor differences in xml serialization.