Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate Member::distinct #3083

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

jamesbt365
Copy link
Member

@jamesbt365 jamesbt365 commented Dec 12, 2024

This method is just wrong, only the username is accompanied by the discriminator, not the global name or nickname, so this method only adds confusion.

@github-actions github-actions bot added model Related to the `model` module. utils Related to the `utils` module. labels Dec 12, 2024
@arqunis arqunis added the enhancement An improvement to Serenity. label Dec 12, 2024
@arqunis arqunis merged commit 452bf82 into serenity-rs:current Dec 12, 2024
22 checks passed
arqunis pushed a commit that referenced this pull request Jan 10, 2025
This is a followup to #3083 as otherwise an `allow(deprecated)` was
being used for a non-deprecated code path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to Serenity. model Related to the `model` module. utils Related to the `utils` module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants