Skip to content

Commit

Permalink
Merge pull request #1109 from serlo/fix-enmeshed
Browse files Browse the repository at this point in the history
Fix enmeshed
  • Loading branch information
kulla authored Nov 10, 2023
2 parents 26add19 + 0ec63a2 commit 64b8b51
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 39 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

All notable changes to this project will be documented in this file.

## [v0.57.10](https://github.com/serlo/api.serlo.org/compare/v0.57.9..v0.57.10) - November 10, 2023

### Fixed

- enmeshed: Do not set surname and given name on init

## [v0.57.9](https://github.com/serlo/api.serlo.org/compare/v0.57.8..v0.57.9) - November 10, 2023

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
"packages/*"
],
"npmClient": "yarn",
"version": "0.57.9"
"version": "0.57.10"
}
2 changes: 1 addition & 1 deletion packages/server/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@serlo/api.serlo.org",
"version": "0.57.9",
"version": "0.57.10",
"private": true,
"repository": "serlo/api.serlo.org",
"license": "Apache-2.0",
Expand Down
37 changes: 0 additions & 37 deletions packages/server/src/internals/server/enmeshed-middleware.ts
Original file line number Diff line number Diff line change
Expand Up @@ -142,43 +142,6 @@ function createEnmeshedInitMiddleware(
mustBeAccepted: true,
title: 'Requested Attributes',
items: [
{
'@type': 'CreateAttributeRequestItem',
mustBeAccepted: true,
attribute: {
'@type': 'IdentityAttribute',
owner: '',
value: {
'@type': 'GivenName',
value: nameParts.length > 0 ? nameParts[0] : '',
},
},
},
{
'@type': 'CreateAttributeRequestItem',
mustBeAccepted: true,
attribute: {
'@type': 'IdentityAttribute',
owner: '',
value: {
'@type': 'Surname',
value:
nameParts.length > 1 ? nameParts[nameParts.length - 1] : '',
},
},
},
{
'@type': 'CreateAttributeRequestItem',
mustBeAccepted: true,
attribute: {
'@type': 'IdentityAttribute',
owner: '',
value: {
'@type': 'Nationality',
value: 'DE',
},
},
},
{
'@type': 'CreateAttributeRequestItem',
mustBeAccepted: true,
Expand Down
5 changes: 5 additions & 0 deletions scripts/changelog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1612,6 +1612,11 @@ async function exec(): Promise<void> {
'enmeshed: Do not set name outside of user journey',
],
},
{
tagName: 'v0.57.10',
date: '2023-11-10',
fixed: ['enmeshed: Do not set surname and given name on init'],
},
],
})

Expand Down

0 comments on commit 64b8b51

Please sign in to comment.