-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: add repo logo, gem downloads badge, center badges #15
base: master
Are you sure you want to change the base?
Conversation
Thank you, @dimitryzub 💯 In the dark mode, shapes seem to have a small white border around them (Not super visable). Maybe we can remove that? |
@aciddjus thank you for having a look🙂 Here's an SVG itself. I guess it's some sort of aliasing but I'm not really sure. When I zoom in, the white border fades away. Zoomed in using touchpad: Aliasing example: |
Could be. Maybe there is some issue with how it's generated. Not sure if you first got an image and then transformed it into SVG, or it was immediately generated as SVG? It's not a big deal. But if others also see it we could recreate this logo as a vector image and export it as SVG. Shouldn't be too difficult since it's a simple shape. This way we can learn if the problem is in the way the image was initially generated or if it's some |
PNG -> SVG via Adobe Illustrator "Trace" method.
👍👍 |
@ilyazub interesting that Illustrator saved the entire thing, including the elephants 👀😄 Could you share from which SVG did you get it? From the commit I did or in the message above?
Yes, it is the case when the illustrator "Trace" method is used. I'm not really sure if it's worth the time to spend adjusting it since the final image will be small and these defects are barely visible or not visible at all, at least to me.
Hm 👍 Update: I'll test with PNG instead and send you an example look. |
I like the last one, but can you crop the image to reduce the margin? I added it to the next version of this library. The current image/file is hosted on GitHub. note: |
Changes in this PR look like this: