Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: add repo logo, gem downloads badge, center badges #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dimitryzub
Copy link

Changes in this PR look like this:

image

@aciddjus
Copy link

Thank you, @dimitryzub 💯

In the dark mode, shapes seem to have a small white border around them (Not super visable). Maybe we can remove that?

image

@dimitryzub
Copy link
Author

dimitryzub commented Apr 25, 2023

@aciddjus thank you for having a look🙂

Here's an SVG itself. I guess it's some sort of aliasing but I'm not really sure. When I zoom in, the white border fades away.

serpapi-ruby-logo-01_01

Zoomed in using touchpad:

image

Aliasing example:

image

@aciddjus
Copy link

I guess it's some sort of aliasing but I'm not really sure.

Could be. Maybe there is some issue with how it's generated. Not sure if you first got an image and then transformed it into SVG, or it was immediately generated as SVG?

It's not a big deal. But if others also see it we could recreate this logo as a vector image and export it as SVG. Shouldn't be too difficult since it's a simple shape. This way we can learn if the problem is in the way the image was initially generated or if it's some
aliasing issue (for example in Adobe Illustrator you can select the "anti-aliasing" option when creating vector graphics).

@dimitryzub
Copy link
Author

Not sure if you first got an image and then transformed it into SVG, or it was immediately generated as SVG?

PNG -> SVG via Adobe Illustrator "Trace" method.

If others also see it we could recreate this logo as a vector image and export it as SVG.

👍👍

@ilyazub
Copy link
Contributor

ilyazub commented Apr 26, 2023

SVG is huge

  • lines are not straight. Gaps between edges is a reason of the "aliasing issue".

    image

  • There are five elephant images on this SVG 🐘

    image

Here's a simplified SVG (still have gaps):

serpapi-ruby

@dimitryzub
Copy link
Author

dimitryzub commented Apr 27, 2023

@ilyazub interesting that Illustrator saved the entire thing, including the elephants 👀😄 Could you share from which SVG did you get it? From the commit I did or in the message above?

lines are not straight.

Yes, it is the case when the illustrator "Trace" method is used. I'm not really sure if it's worth the time to spend adjusting it since the final image will be small and these defects are barely visible or not visible at all, at least to me.

Gaps between edges is a reason of the "aliasing issue".

Hm 👍

Update: I'll test with PNG instead and send you an example look.

@dimitryzub
Copy link
Author

dimitryzub commented May 1, 2023

@aciddjus @ilyazub What do you think about PNG instead of SVG?

Example:

Google Search Results in Ruby

google-search-results-ruby-logo

@jvmvik
Copy link
Contributor

jvmvik commented May 6, 2023

I like the last one, but can you crop the image to reduce the margin?
ideally, only 10px around the logo is enough.

I added it to the next version of this library.
https://github.com/serpapi/serpapi-ruby

The current image/file is hosted on GitHub.
Should we host the logo under serpapi.com? or under the repository itself?
There is a risk that github deletes the image.

note:
tests are failing because forks are not allowed to run tests using secret (API_KEY).
next time you can just create a feature branch from this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants