Fix onDisable methods.

seyfahni · May 7, 2019 · f702949 · f702949
1 parent 47a5a99
commit f702949
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 5 deletions.
diff --git a/src/main/java/mr/minecraft15/onlinetime/bukkit/OnlineTimeBukkitPlugin.java b/src/main/java/mr/minecraft15/onlinetime/bukkit/OnlineTimeBukkitPlugin.java
@@ -62,7 +62,7 @@ public class OnlineTimeBukkitPlugin extends JavaPlugin implements PluginProxy {
     private AccumulatingOnlineTimeStorage onlineTimeStorage;
     private PlayerNameStorage playerNameStorage;
 
-    BukkitTask flushCacheTask;
+    private BukkitTask flushCacheTask;
 
     @Override
     public void onEnable() {
@@ -249,7 +249,22 @@ private void flushOnlineTimeCache() {
 
     @Override
     public void onDisable() {
-
+        if (onlineTimeStorage != null) {
+            try {
+                flushCacheTask.cancel();
+                flushOnlineTimeCache();
+                onlineTimeStorage.close();
+            } catch (StorageException ex) {
+                getLogger().log(Level.SEVERE, "error while closing online time storage", ex);
+            }
+        }
+        if (playerNameStorage != null) {
+            try {
+                playerNameStorage.close();
+            } catch (StorageException ex) {
+                getLogger().log(Level.SEVERE, "error while closing player name storage", ex);
+            }
+        }
     }
 
     @Override

diff --git a/src/main/java/mr/minecraft15/onlinetime/bungee/OnlineTimeBungeePlugin.java b/src/main/java/mr/minecraft15/onlinetime/bungee/OnlineTimeBungeePlugin.java
@@ -44,7 +44,6 @@
 import java.util.*;
 import java.util.concurrent.TimeUnit;
 import java.util.logging.Level;
-import java.util.regex.Matcher;
 import java.util.stream.Collectors;
 
 public class OnlineTimeBungeePlugin extends Plugin implements PluginProxy {
@@ -93,10 +92,10 @@ public void onEnable() {
     public void onDisable() {
         getProxy().getPluginManager().unregisterCommands(this);
         getProxy().getPluginManager().unregisterListeners(this);
-        flushCacheTask.cancel();
-        flushOnlineTimeCache();
         if (onlineTimeStorage != null) {
             try {
+                flushCacheTask.cancel();
+                flushOnlineTimeCache();
                 onlineTimeStorage.close();
             } catch (StorageException ex) {
                 getLogger().log(Level.SEVERE, "error while closing online time storage", ex);