[WIP] remove stack indication from effect name in order to display correct … #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Realized it still wasn't updating scorch properly when at 5 stacks because you need to use different events once you're at 5 stacks. Not sure the best way to handle this in a generic way right now just checking for spell == "Scorch" |
shagu
changed the title
* red: attacking player * yellow: attacking other * blue: no target (npc only) * none: out of combat This only works if super-wow is enabled.
Thanks @Otari98 for the idea and implementation via: shagu/ShaguPlates#30
Due to the secure frame requirements in TBC, this option only exists in vanilla.
The feature is also experimental, as it removes the OnEnter/OnLeave events. There
is a ':Click' that can be called on the parent, but there is no ':Enter' or ':Leave'
that could be called to run the scripts. The parent also have no GetScript("OnEnter")
so there's no way to access the script that changes the color and shows the tooltip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…expiration time
not sure if this is specific to turtle wow but scorch timer never gets refreshed because the effect name for each stack is different
it goes
Fire Vulnerability
Fire Vulnerability (2)
Fire Vulnerability (3)
Fire Vulnerability (4)
Fire Vulnerability (5)