Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skin: QuickHeal / Decursive #1362

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

shikulja
Copy link
Contributor

@shikulja shikulja commented Nov 9, 2024

ps. I think need to add pfui.api to manage skin settings

image
image
image
image

image

#1173

@shikulja
Copy link
Contributor Author

shikulja commented Nov 9, 2024

for colouring, can be used, pfui globals but i not sure

- adds more skining.
strange places:
- cant apply SkinEditBox for "QuickHealConfig_NotificationChannelNameEditBox"
- dropdowns not fully skined
Im done.
@shikulja shikulja changed the title skin: QuickHealHealingBar skin: Quick Heal Nov 24, 2024
@shikulja shikulja changed the title skin: Quick Heal skin: QuickHeal Nov 24, 2024
@shikulja shikulja changed the title skin: QuickHeal skin: QuickHeal / Decursive Dec 13, 2024
@shagu
Copy link
Owner

shagu commented Dec 13, 2024

I really like to move the skins from thirdparty-vanilla.lua to the skin directory in future.
It makes sense to have them there. Just saying what you're doing is the right thing, but I can't merge it until that transition is done. Skins should be either in thirdparty-vanilla.lua or in skins/, so I will leave this PR open until then.

Please continue what you're doing, happy holidays and thank you for your contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants